Changeset 55185

Timestamp:

02/01/2023 10:57:04 PM (23 months ago)

Author:

flixos90

Message:

Editor: Use a non-persistent object cache instead of transient in wp_get_global_stylesheet().

This changeset is part of a greater effort to enhance the caching strategy for theme.json based data. Similar to [55138], [55148], and [55155], the cache is currently ignored when WP_DEBUG is on to avoid interrupting the theme developer's workflow.

Props spacedmonkey, oandregal, flixos90, ajlende, hellofromtonya.
Fixes #57568.

Location:

trunk

Files:

• src/wp-includes/global-styles-and-settings.php (modified) (3 diffs)
• tests/phpunit/tests/theme/wpGetGlobalStylesSvgFilters.php (added)

trunk/src/wp-includes/global-styles-and-settings.php

@@ -234 +234 @@
  */
 function wp_get_global_styles_svg_filters() {
-    // Return cached value if it can be used and exists.
-    // It's cached by theme to make sure that theme switching clears the cache.
-    $can_use_cached = (
-        ( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) &&
-        ( ! defined( 'SCRIPT_DEBUG' ) || ! SCRIPT_DEBUG ) &&
-        ( ! defined( 'REST_REQUEST' ) || ! REST_REQUEST ) &&
-        ! is_admin()
-    );
-    $transient_name = 'global_styles_svg_filters_' . get_stylesheet();
-    if ( $can_use_cached ) {
-        $cached = get_transient( $transient_name );
+    /*
+     * Ignore cache when `WP_DEBUG` is enabled, so it doesn't interfere with the theme
+     * developer's workflow.
+     *
+     * @todo Replace `WP_DEBUG` once an "in development mode" check is available in Core.
+     */
+    $can_use_cached = ! WP_DEBUG;
+    $cache_group    = 'theme_json';
+    $cache_key      = 'wp_get_global_styles_svg_filters';
+    if ( $can_use_cached ) {
+        $cached = wp_cache_get( $cache_key, $cache_group );
         if ( $cached ) {
             return $cached;
@@ -261 +261 @@
 
     if ( $can_use_cached ) {
-        // Cache for a minute, same as wp_get_global_stylesheet.
-        set_transient( $transient_name, $svgs, MINUTE_IN_SECONDS );
+        wp_cache_set( $cache_key, $svgs, $cache_group );
     }
 
@@ -368 +367 @@
 function wp_clean_theme_json_cache() {
     wp_cache_delete( 'wp_get_global_stylesheet', 'theme_json' );
+    wp_cache_delete( 'wp_get_global_styles_svg_filters', 'theme_json' );
     wp_cache_delete( 'wp_get_global_settings_custom', 'theme_json' );
     wp_cache_delete( 'wp_get_global_settings_theme', 'theme_json' );