Changeset 55218

Timestamp:

02/03/2023 10:23:19 PM (23 months ago)

Author:

joedolson

Message:

Media: Hide 'view' link if empty string passed to attachment_link.

Fix empty href attribute on 'View' link when the attachment_link filter is used to hide attachment pages.

Props oh_hello, iqbalrony.
Fixes #54824.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -769 +769 @@
             }
 
-            $actions['view'] = sprintf(
-                '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
-                get_permalink( $post->ID ),
-                /* translators: %s: Attachment title. */
-                esc_attr( sprintf( __( 'View &#8220;%s&#8221;' ), $att_title ) ),
-                __( 'View' )
-            );
+            if ( get_permalink( $post->ID ) ) {
+                $actions['view'] = sprintf(
+                    '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
+                    get_permalink( $post->ID ),
+                    /* translators: %s: Attachment title. */
+                    esc_attr( sprintf( __( 'View &#8220;%s&#8221;' ), $att_title ) ),
+                    __( 'View' )
+                );
+            }
 
             if ( current_user_can( 'edit_post', $post->ID ) ) {
@@ -830 +832 @@
 
             if ( ! $this->is_trash ) {
-                $actions['view'] = sprintf(
-                    '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
-                    get_permalink( $post->ID ),
-                    /* translators: %s: Attachment title. */
-                    esc_attr( sprintf( __( 'View &#8220;%s&#8221;' ), $att_title ) ),
-                    __( 'View' )
-                );
+                if ( get_permalink( $post->ID ) ) {
+                    $actions['view'] = sprintf(
+                        '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
+                        get_permalink( $post->ID ),
+                        /* translators: %s: Attachment title. */
+                        esc_attr( sprintf( __( 'View &#8220;%s&#8221;' ), $att_title ) ),
+                        __( 'View' )
+                    );
+                }
 
                 $actions['copy'] = sprintf(