Changeset 55245 for trunk/src/wp-includes/formatting.php

Timestamp:

02/07/2023 03:32:43 AM (3 years ago)

Author:

peterwilsoncc

Message:

Formatting: Guard wp_strip_all_tags() against fatal errors.

Check the input of wp_strip_all_tags() before passing it to strip_tags(). This protects against fatal errors introduced in PHP 8, retaining the E_USER_WARNING from PHP 7, and prevents a PHP 8.1 deprecation notice when passing null.

Props chocofc1, costdev, jrf, dd32, audrasjb, peterwilsoncc.
Fixes #56434.

File:

• trunk/src/wp-includes/formatting.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -5396 +5396 @@
  */
 function wp_strip_all_tags( $text, $remove_breaks = false ) {
+    if ( is_null( $text ) ) {
+        return '';
+    }
+
+    if ( ! is_scalar( $text ) ) {
+        /*
+         * To maintain consistency with pre-PHP 8 error levels,
+         * trigger_error() is used to trigger an E_USER_WARNING,
+         * rather than _doing_it_wrong(), which triggers an E_USER_NOTICE.
+         */
+        trigger_error(
+            sprintf(
+                /* translators: 1: The function name, 2: The argument number, 3: The argument name, 4: The expected type, 5: The provided type. */
+                __( 'Warning: %1$s expects parameter %2$s (%3$s) to be a %4$s, %5$s given.' ),
+                __FUNCTION__,
+                '#1',
+                '$text',
+                'string',
+                gettype( $text )
+            ),
+            E_USER_WARNING
+        );
+
+        return '';
+    }
+
     $text = preg_replace( '@<(script|style)[^>]*?>.*?</\\1>@si', '', $text );
     $text = strip_tags( $text );