Changeset 55252

Timestamp:

02/07/2023 12:07:46 PM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Implement wp_cache_get_multiple in wp_queue_posts_for_term_meta_lazyload.

In [47938] the wp_cache_get_multiple function was added to core. This function allows for multiple cache keys to be received from cache in a single function call. wp_queue_posts_for_term_meta_lazyload function does many calls to cache. To get taxonomy relationship for multiple posts and get all terms. Replace calls to get_object_term_cache with calls to wp_cache_get_multiple and _prime_term_caches. This improves performance on sites that implement the wp_cache_get_multiple in their object caching drop-in.

Props spacedmonkey, ocean90, SergeyBiryukov, costdev, flixos90, joemcgill, 10upsimon.
Fixes #57150.

Location:

trunk

Files:

• src/wp-includes/class-wp-query.php (modified) (1 diff)
• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/includes/abstract-testcase.php (modified) (1 diff)
• tests/phpunit/tests/query/lazyLoadTermMeta.php (added)

trunk/src/wp-includes/class-wp-query.php

@@ -1949 +1949 @@
                 if ( ! isset( $q['lazy_load_term_meta'] ) ) {
                         $q['lazy_load_term_meta'] = $q['update_post_term_cache'];
+                } elseif ( $q['lazy_load_term_meta'] ) { // Lazy loading term meta only works if term caches are primed.
+                        $q['update_post_term_cache'] = true;
                 }
 

trunk/src/wp-includes/post.php

@@ -7780 +7780 @@
 function wp_queue_posts_for_term_meta_lazyload( $posts ) {
         $post_type_taxonomies = array();
-        $term_ids             = array();
+        $prime_post_terms     = array();
         foreach ( $posts as $post ) {
                 if ( ! ( $post instanceof WP_Post ) ) {
@@ -7791 +7791 @@
 
                 foreach ( $post_type_taxonomies[ $post->post_type ] as $taxonomy ) {
-                        // Term cache should already be primed by `update_post_term_cache()`.
-                        $terms = get_object_term_cache( $post->ID, $taxonomy );
-                        if ( false !== $terms ) {
-                                foreach ( $terms as $term ) {
-                                        if ( ! in_array( $term->term_id, $term_ids, true ) ) {
-                                                $term_ids[] = $term->term_id;
+                        $prime_post_terms[ $taxonomy ][] = $post->ID;
+                }
+        }
+
+        $term_ids = array();
+        if ( $prime_post_terms ) {
+                $prime_term_ids     = array();
+                $prime_taxonomy_ids = array();
+                foreach ( $prime_post_terms as $taxonomy => $post_ids ) {
+                        $cached_term_ids = wp_cache_get_multiple( $post_ids, "{$taxonomy}_relationships" );
+                        if ( is_array( $cached_term_ids ) ) {
+                                $cached_term_ids = array_filter( $cached_term_ids );
+                                foreach ( $cached_term_ids as $term_ids ) {
+                                        // Backward compatibility for if a plugin is putting objects into the cache, rather than IDs.
+                                        foreach ( $term_ids as $term_id ) {
+                                                if ( is_numeric( $term_id ) ) {
+                                                        $prime_term_ids[]                  = (int) $term_id;
+                                                        $prime_taxonomy_ids[ $taxonomy ][] = (int) $term_id;
+                                                } elseif ( isset( $term_id->term_id ) ) {
+                                                        $prime_taxonomy_ids[ $taxonomy ][] = (int) $term_id->term_id;
+                                                        $prime_term_ids[]                  = (int) $term_id->term_id;
+                                                }
                                         }
+                                }
+                        }
+                }
+
+                if ( $prime_term_ids ) {
+                        $prime_term_ids = array_unique( $prime_term_ids );
+                        // Do not prime term meta at this point, let the lazy loader take care of that.
+                        _prime_term_caches( $prime_term_ids, false );
+
+                        foreach ( $prime_taxonomy_ids as $taxonomy => $_term_ids ) {
+                                foreach ( $_term_ids as $term_id ) {
+                                        if ( in_array( $term_id, $term_ids, true ) ) {
+                                                continue;
+                                        }
+                                        $term = get_term( $term_id, $taxonomy );
+                                        if ( is_wp_error( $term ) ) {
+                                                continue;
+                                        }
+
+                                        $term_ids[] = $term_id;
                                 }
                         }

trunk/tests/phpunit/includes/abstract-testcase.php

@@ -195 +195 @@
                 $this->_restore_hooks();
                 wp_set_current_user( 0 );
+
+                $lazyloader = wp_metadata_lazyloader();
+                $lazyloader->reset_queue( 'term' );
+                $lazyloader->reset_queue( 'comment' );
         }