Changeset 55289 for trunk/src/wp-includes/comment-template.php

Timestamp:

02/07/2023 06:52:24 PM (2 years ago)

Author:

jorbin

Message:

Comments: Improve rel attribute usage in comments.

Internal links should be followed and it should be easier to modify other rel attributes on comments. This adds a helper function for determining if a URL is internal and also adds some new filters to make it easy to modify rel attributes in comments.

Props thomasplevy, desrosj, sabernhardt, benish74, samiamnot, galbaras, jorbin.

Fixes #53290, #56444.

File:

• trunk/src/wp-includes/comment-template.php (modified) (2 diffs)

trunk/src/wp-includes/comment-template.php

@@ -219 +219 @@
  */
 function get_comment_author_link( $comment_ID = 0 ) {
-    $comment = get_comment( $comment_ID );
-    $url     = get_comment_author_url( $comment );
-    $author  = get_comment_author( $comment );
+    $comment    = get_comment( $comment_ID );
+    $comment_ID = ! empty( $comment->comment_ID ) ? $comment->comment_ID : (string) $comment_ID;
+    $url        = get_comment_author_url( $comment );
+    $author     = get_comment_author( $comment );
 
     if ( empty( $url ) || 'http://' === $url ) {
         $return = $author;
     } else {
-        $return = "<a href='$url' rel='external nofollow ugc' class='url'>$author</a>";
+        $rel_parts = array( 'ugc' );
+        if ( ! wp_is_internal_link( $url ) ) {
+            $rel_parts = array_merge(
+                $rel_parts,
+                array( 'external', 'nofollow' )
+            );
+        }
+
+        /**
+         * Filters the rel attributes of the comment author's link.
+         *
+         * @since 6.2.0
+         *
+         * @param string[]   $rel_parts An array of strings representing the rel
+         *                              tags which will be joined into the anchor's
+         *                              rel attribute.
+         * @param WP_Comment $comment   The comment object
+         */
+        $rel_parts = apply_filters( 'comment_author_link_rel', $rel_parts, $comment );
+
+        $rel = implode( ' ', $rel_parts );
+        $rel = esc_attr( $rel );
+        // empty space before rel necessary for later sprintf.
+        $rel = ! empty( $rel ) ? sprintf( ' rel="%s"', $rel ) : '';
+
+        $return = sprintf(
+            '<a href="%1$s" class="url"%2$s>%3$s</a>',
+            $url,
+            $rel,
+            $author
+        );
     }
 
@@ -240 +271 @@
      * @param string $comment_ID The comment ID as a numeric string.
      */
-    return apply_filters( 'get_comment_author_link', $return, $author, $comment->comment_ID );
+    return apply_filters( 'get_comment_author_link', $return, $author, $comment_ID );
 }