Changeset 55289 for trunk/tests/phpunit/tests/formatting/wpRelUgc.php

Timestamp:

02/07/2023 06:52:24 PM (22 months ago)

Author:

jorbin

Message:

Comments: Improve rel attribute usage in comments.

Internal links should be followed and it should be easier to modify other rel attributes on comments. This adds a helper function for determining if a URL is internal and also adds some new filters to make it easy to modify rel attributes in comments.

Props thomasplevy, desrosj, sabernhardt, benish74, samiamnot, galbaras, jorbin.

Fixes #53290, #56444.

File:

• trunk/tests/phpunit/tests/formatting/wpRelUgc.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/wpRelUgc.php

@@ -12 +12 @@
      */
     public function test_add_ugc() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
         $content  = '<p>This is some cool <a href="/">Code</a></p>';
         $expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow ugc\">Code</a></p>';
@@ -31 +21 @@
      */
     public function test_convert_ugc() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
         $content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
         $expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow ugc\">Code</a></p>';
@@ -51 +31 @@
      */
     public function test_wp_rel_ugc( $input, $output, $expect_deprecation = false ) {
-        if ( true === $expect_deprecation && PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
         $this->assertSame( wp_slash( $output ), wp_rel_ugc( $input ) );
     }
@@ -100 +70 @@
             array(
                 '<a href="' . $home_url_http . '/some-url">Home URL (http)</a>',
-                '<a href="' . $home_url_http . '/some-url">Home URL (http)</a>',
+                '<a href="' . $home_url_http . '/some-url" rel="ugc">Home URL (http)</a>',
             ),
             array(
                 '<a href="' . $home_url_https . '/some-url">Home URL (https)</a>',
-                '<a href="' . $home_url_https . '/some-url">Home URL (https)</a>',
+                '<a href="' . $home_url_https . '/some-url" rel="ugc">Home URL (https)</a>',
             ),
         );
@@ -110 +80 @@
 
     public function test_append_ugc_with_valueless_attribute() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
 
         $content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';