Changeset 55296 for trunk/src/wp-admin/includes/update-core.php

Timestamp:

02/08/2023 03:01:32 PM (20 months ago)

Author:

hellofromTonya

Message:

Upgrade/Install: Skip preloading Requests for WordPress versions before 4.6.

Skip preloading Requests files in _preload_old_requests_classes_and_interfaces() when updating from a WordPress version older than 4.6.

Why?

Requests library was first introduced into WordPress 4.6 via #33055 / [37428]. If a user is upgrading from a version older than 4.6, this changeset prevents the Requests preloading to prevent a fatal error of attempting to load files that do not exist in their current WordPress version.

Follow-up to [54997], [37428].

Props afragen, costdev, ironprogrammer, antonvlasenko.
Fixes #57662.

File:

• trunk/src/wp-admin/includes/update-core.php (modified) (1 diff)

trunk/src/wp-admin/includes/update-core.php

@@ -1596 +1596 @@
  * @global array              $_old_requests_files Requests files to be preloaded.
  * @global WP_Filesystem_Base $wp_filesystem       WordPress filesystem subclass.
+ * @global string             $wp_version          The WordPress version string.
  *
  * @param string $to Path to old WordPress installation.
  */
 function _preload_old_requests_classes_and_interfaces( $to ) {
-    global $_old_requests_files, $wp_filesystem;
+    global $_old_requests_files, $wp_filesystem, $wp_version;
+
+    /*
+     * Requests was introduced in WordPress 4.6.
+     *
+     * Skip preloading if the website was previously using
+     * an earlier version of WordPress.
+     */
+    if ( version_compare( $wp_version, '4.6', '<' ) ) {
+        return;
+    }
 
     if ( ! defined( 'REQUESTS_SILENCE_PSR0_DEPRECATIONS' ) ) {