Changeset 55322

Timestamp:

02/13/2023 07:35:13 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Declare the $post_id property in wp_comments_personal_data_exporter() tests.

Use the same approach in wp_comments_personal_data_eraser() for consistency and to minimize the number of fixtures created in each individual test.

Follow-up to [55319], [55321].

Props hellofromTonya.
See #56793.

Location:

trunk/tests/phpunit/tests/comment

Files:

• wpCommentsPersonalDataEraser.php (modified) (6 diffs)
• wpCommentsPersonalDataExporter.php (modified) (1 diff)

trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataEraser.php

@@ -9 +9 @@
 class Tests_Comment_wpCommentsPersonalDataEraser extends WP_UnitTestCase {
 
+        protected static $post_id;
+
+        public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+                self::$post_id = $factory->post->create();
+        }
+
         /**
          * The `wp_comments_personal_data_eraser()` function should erase user's comments.
@@ -16 +22 @@
         public function test_wp_comments_personal_data_eraser() {
 
-                $post_id = self::factory()->post->create();
                 $user_id = self::factory()->user->create();
 
                 $args       = array(
                         'user_id'              => $user_id,
-                        'comment_post_ID'      => $post_id,
+                        'comment_post_ID'      => self::$post_id,
                         'comment_author'       => 'Comment Author',
                         'comment_author_email' => 'personal@local.host',
@@ -90 +95 @@
         public function test_wp_comments_personal_data_eraser_non_empty_first_page_output() {
 
-                $post_id = self::factory()->post->create();
-                $args    = array(
-                        'comment_post_ID'      => $post_id,
+                $args = array(
+                        'comment_post_ID'      => self::$post_id,
                         'comment_author'       => 'Comment Author',
                         'comment_author_email' => 'personal@local.host',
@@ -121 +125 @@
         public function test_wp_comments_personal_data_eraser_empty_second_page_output() {
 
-                $post_id = self::factory()->post->create();
-                $args    = array(
-                        'comment_post_ID'      => $post_id,
+                $args = array(
+                        'comment_post_ID'      => self::$post_id,
                         'comment_author'       => 'Comment Author',
                         'comment_author_email' => 'personal@local.host',
@@ -152 +155 @@
         public function test_wp_anonymize_comment_filter_to_prevent_comment_anonymization() {
 
-                $post_id    = self::factory()->post->create();
                 $args       = array(
-                        'comment_post_ID'      => $post_id,
+                        'comment_post_ID'      => self::$post_id,
                         'comment_author'       => 'Comment Author',
                         'comment_author_email' => 'personal@local.host',
@@ -188 +190 @@
         public function test_wp_anonymize_comment_filter_to_prevent_comment_anonymization_with_custom_message() {
 
-                $post_id    = self::factory()->post->create();
                 $args       = array(
-                        'comment_post_ID'      => $post_id,
+                        'comment_post_ID'      => self::$post_id,
                         'comment_author'       => 'Comment Author',
                         'comment_author_email' => 'personal@local.host',

trunk/tests/phpunit/tests/comment/wpCommentsPersonalDataExporter.php

@@ -8 +8 @@
  */
 class Tests_Comment_wpCommentsPersonalDataExporter extends WP_UnitTestCase {
+
+        protected static $post_id;
+
+        public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+                self::$post_id = $factory->post->create();
+        }
 
         /**