Make WordPress Core

Changeset 55325


Ignore:
Timestamp:
02/13/2023 11:08:23 PM (16 months ago)
Author:
hellofromTonya
Message:

REST API: Remove 'Invalid user ID' error in WP_REST_Users_Controller::update_item().

Removes the WP_Error code for 'Invalid user ID.'. Why?

tl;dr
This branch will never be entered as the $user will never be falsey.

Longer reasoning:

[39954] introduced WP_REST_Users_Controller::get_user() method to encapsulate getting the user and handling the 'Invalid user ID.' WP_Error. It replaced get_userdata() in WP_REST_Users_Controller::update_item() but left the existing 'Invalid user ID.' WP_Error introduced in [38832].

The code removed in this changeset will never be reached because $user will never be falsey. Rather, WP_REST_Users_Controller::get_user() will always return an instance of WP_Error or WP_User.

Could the user's ID be falsey?
No. Why? WP_REST_Users_Controller::get_user() checks that the user exists, which checks if the ID is falsey.

Therefore, the code can safely be removed.

Follow-up to [39954], [38832].

Props jrf, costdev, hellofromTonya, SergeyBiryukov.
Fixes #56662.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php

    r54891 r55325  
    718718        $id = $user->ID;
    719719
    720         if ( ! $user ) {
    721             return new WP_Error(
    722                 'rest_user_invalid_id',
    723                 __( 'Invalid user ID.' ),
    724                 array( 'status' => 404 )
    725             );
    726         }
    727 
    728720        $owner_id = false;
    729721        if ( is_string( $request['email'] ) ) {
Note: See TracChangeset for help on using the changeset viewer.