Changeset 55341

Timestamp:

02/14/2023 06:19:34 PM (19 months ago)

Author:

hellofromTonya

Message:

Build/Test Tools: Fix inaccurate coverage in Tests_Functions_wpListPluck::set_up().

The call stack for WP_UnitTestCase_Base::set_up() includes a call to WP_List_Util::pluck(), which creates an inaccurate coverage report for this method.

To resolve, parent::set_up() is removed from Tests_Functions_wpListPluck::set_up().

To ensure that deprecation and incorrect usage notices continue to be detectable, $this->expectDeprecated() is added in the test's set_up() fixture.

Follow-up to [51663], [28900].

Props costdev, jrf, SergeyBiryukov, audrasjb.
Fixes #56706.

File:

• trunk/tests/phpunit/tests/functions/wpListPluck.php (modified) (1 diff)

trunk/tests/phpunit/tests/functions/wpListPluck.php

@@ -12 +12 @@
 
     public function set_up() {
-        parent::set_up();
+        /*
+         * This method deliberately does not call parent::set_up(). Why?
+         *
+         * The call stack for WP_UnitTestCase_Base::set_up() includes a call to
+         * WP_List_Util::pluck(), which creates an inaccurate coverage report
+         * for this method.
+         *
+         * To ensure that deprecation and incorrect usage notices continue to be
+         * detectable, this method uses WP_UnitTestCase_Base::expectDeprecated().
+         */
+        $this->expectDeprecated();
+
         $this->array_list['foo'] = array(
             'name'   => 'foo',