Changeset 55345 for trunk/tests/phpunit/tests/theme/wpThemeJson.php

Timestamp:

02/15/2023 03:55:12 AM (10 months ago)

Author:

peterwilsoncc

Message:

Editor: Prevent KSES stripping global layout style properties.

Layout style properties are stored using indirect values, rather than direct CSS properties.

Allow users without the unfiltered_html capability to modify global styles using the indirect block spacing properties contentSize, wideSize, and blockGap, using a mapping of the eventual CSS property to the indirect property stored in theme.json. The mapped CSS property is then used for CSS validation.

Props andrewserong, costdev, hellofromtonya, mamaduka, mmtr86.
Fixes #57321.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -2428 +2428 @@
 
     /**
+     * @ticket 57321
+     *
+     * @covers WP_Theme_JSON::remove_insecure_properties
+     */
+    public function test_remove_insecure_properties_should_allow_indirect_properties() {
+        $actual = WP_Theme_JSON::remove_insecure_properties(
+            array(
+                'version'  => WP_Theme_JSON::LATEST_SCHEMA,
+                'styles'   => array(
+                    'spacing' => array(
+                        'blockGap' => '3em',
+                    ),
+                    'blocks'  => array(
+                        'core/social-links' => array(
+                            'spacing' => array(
+                                'blockGap' => array(
+                                    'left' => '2em',
+                                    'top'  => '1em',
+                                ),
+                            ),
+                        ),
+                    ),
+                ),
+                'settings' => array(
+                    'layout' => array(
+                        'contentSize' => '800px',
+                        'wideSize'    => '1000px',
+                    ),
+                ),
+            )
+        );
+
+        $expected = array(
+            'version'  => WP_Theme_JSON::LATEST_SCHEMA,
+            'styles'   => array(
+                'spacing' => array(
+                    'blockGap' => '3em',
+                ),
+                'blocks'  => array(
+                    'core/social-links' => array(
+                        'spacing' => array(
+                            'blockGap' => array(
+                                'left' => '2em',
+                                'top'  => '1em',
+                            ),
+                        ),
+                    ),
+                ),
+            ),
+            'settings' => array(
+                'layout' => array(
+                    'contentSize' => '800px',
+                    'wideSize'    => '1000px',
+                ),
+            ),
+        );
+
+        $this->assertSameSetsWithIndex( $expected, $actual );
+    }
+
+    /**
      * @ticket 56467
      */