Changeset 55433

Timestamp:

02/28/2023 01:20:04 PM (20 months ago)

Author:

SergeyBiryukov

Message:

Users: Adjust the initialization of the $duplicated_keys array in wp_salt().

This avoids an endless loop if get_current_user_id() is used in a callback attached to the gettext filter.

With the translated phrase moved into a separate assignment, the function succeeds in setting the static $duplicated_keys array once and no longer goes into this code section on subsequent calls.

Follow-up to [54249].

Props adityaarora010196, SergeyBiryukov.
Fixes #57121.

File:

• trunk/src/wp-includes/pluggable.php (modified) (1 diff)

trunk/src/wp-includes/pluggable.php

@@ -2418 +2418 @@
         if ( null === $duplicated_keys ) {
             $duplicated_keys = array(
-                'put your unique phrase here'       => true,
-                /*
-                 * translators: This string should only be translated if wp-config-sample.php is localized.
-                 * You can check the localized release package or
-                 * https://i18n.svn.wordpress.org/<locale code>/branches/<wp version>/dist/wp-config-sample.php
-                 */
-                __( 'put your unique phrase here' ) => true,
+                'put your unique phrase here' => true,
             );
+
+            /*
+             * translators: This string should only be translated if wp-config-sample.php is localized.
+             * You can check the localized release package or
+             * https://i18n.svn.wordpress.org/<locale code>/branches/<wp version>/dist/wp-config-sample.php
+             */
+            $duplicated_keys[ __( 'put your unique phrase here' ) ] = true;
+
             foreach ( array( 'AUTH', 'SECURE_AUTH', 'LOGGED_IN', 'NONCE', 'SECRET' ) as $first ) {
                 foreach ( array( 'KEY', 'SALT' ) as $second ) {