Changeset 55444

Timestamp:

03/01/2023 03:37:06 PM (22 months ago)

Author:

SergeyBiryukov

Message:

Users: Use a separate variable for the post counts query in wp_list_authors().

This avoids a collision if wp_list_authors() is called with the optioncount parameter enabled, and the resulting array for the post counts query contains a key that matches the ID of a user who does not have any posts.

Follow-up to [54262].

Props peterwilsoncc, johnbillion, lifeboat, brookedot, thedaysse, Toru.
Fixes #57011.

Location:

trunk

Files:

• src/wp-includes/author-template.php (modified) (2 diffs)
• tests/phpunit/tests/user/wpListAuthors.php (modified) (1 diff)

trunk/src/wp-includes/author-template.php

@@ -482 +482 @@
 
     if ( ! is_array( $post_counts ) ) {
-        $post_counts = $wpdb->get_results(
+        $post_counts       = array();
+        $post_counts_query = $wpdb->get_results(
             "SELECT DISTINCT post_author, COUNT(ID) AS count
             FROM $wpdb->posts
@@ -489 +490 @@
         );
 
-        foreach ( (array) $post_counts as $row ) {
+        foreach ( (array) $post_counts_query as $row ) {
             $post_counts[ $row->post_author ] = $row->count;
         }

trunk/tests/phpunit/tests/user/wpListAuthors.php

@@ -147 +147 @@
     }
 
+    /**
+     * Ensures the 'optioncount' parameter does not throw an error when there are authors without posts.
+     *
+     * @ticket 57011
+     */
+    public function test_wp_list_authors_optioncount_should_not_error_for_empty_authors() {
+        /*
+         * The main purpose of this test is to ensure that the error below is not thrown:
+         *
+         * Error: Object of class stdClass could not be converted to string
+         *
+         * In place of direct testing we ensure `wp_list_authors()` returns a list of authors
+         * at least one of which is empty.
+         */
+        $actual = wp_list_authors(
+            array(
+                'optioncount'   => true,
+                'hide_empty'    => false,
+                'exclude_admin' => false,
+                'echo'          => false,
+            )
+        );
+        $this->assertStringContainsString( '(0)', $actual );
+    }
+
     public function test_wp_list_authors_exclude_admin() {
         self::factory()->post->create(