Changeset 55446 for trunk/src/wp-includes/blocks.php

Timestamp:

03/01/2023 03:56:50 PM (20 months ago)

Author:

audrasjb

Message:

Script Loader: Pass the asset path to the _doing_it_wrong() notice in register_block_script_handle().

This changeset ensures the file path is correctly passed in the output from _doing_it_wrong() notice in register_block_script_handle().

Props desrosj, neychok, mahbubshovan, ironprogrammer, robinwpdeveloper, hellofromTonya, simongomes02, mukesh27, costdev.
Fixes #53566.

File:

• trunk/src/wp-includes/blocks.php (modified) (1 diff)

trunk/src/wp-includes/blocks.php

@@ -108 +108 @@
     }
 
-    $script_handle     = generate_block_asset_handle( $metadata['name'], $field_name, $index );
-    $script_asset_path = wp_normalize_path(
-        realpath(
-            dirname( $metadata['file'] ) . '/' .
-            substr_replace( $script_path, '.asset.php', - strlen( '.js' ) )
-        )
-    );
-    if ( ! file_exists( $script_asset_path ) ) {
+    $script_asset_raw_path = dirname( $metadata['file'] ) . '/' . substr_replace( $script_path, '.asset.php', - strlen( '.js' ) );
+    $script_handle         = generate_block_asset_handle( $metadata['name'], $field_name, $index );
+    $script_asset_path     = wp_normalize_path(
+        realpath( $script_asset_raw_path )
+    );
+
+    if ( empty( $script_asset_path ) ) {
         _doing_it_wrong(
             __FUNCTION__,
             sprintf(
-                /* translators: 1: Field name, 2: Block name. */
-                __( 'The asset file for the "%1$s" defined in "%2$s" block definition is missing.' ),
+                /* translators: 1: Asset file location, 2: Field name, 3: Block name.  */
+                __( 'The asset file (%1$s) for the "%2$s" defined in "%3$s" block definition is missing.' ),
+                $script_asset_raw_path,
                 $field_name,
                 $metadata['name']