Changeset 55465

Timestamp:

03/06/2023 02:44:35 PM (19 months ago)

Author:

hellofromTonya

Message:

Build/Test Tooling: Use assertSame() in WP_Date_Query tests.

Change from assertEquals() to assertSame(). Why? To ensure both the return value and data type match the expected results.

Follow-up to [54530].

Props costdev, peterwilsoncc, mukesh27, ankitmaru.
See #56800.

File:

• trunk/tests/phpunit/tests/date/query.php (modified) (3 diffs)

trunk/tests/phpunit/tests/date/query.php

@@ -1187 +1187 @@
         $parts = mb_split( '\)\s+AND\s+\(', $sql );
         $this->assertIsArray( $parts, 'SQL query cannot be split into multiple parts using operator AND.' );
-        $this->assertEquals( 2, count( $parts ), 'SQL query does not contain correct number of AND operators.' );
+        $this->assertSame( 2, count( $parts ), 'SQL query does not contain correct number of AND operators.' );
 
         $this->assertStringNotContainsString( 'OR', $sql, 'SQL query contains conditions joined by operator OR.' );
@@ -1234 +1234 @@
         $parts = mb_split( '\)\s+OR\s+\(', $sql );
         $this->assertIsArray( $parts, 'SQL query cannot be split into multiple parts using operator OR.' );
-        $this->assertEquals( 2, count( $parts ), 'SQL query does not contain correct number of OR operators.' );
+        $this->assertSame( 2, count( $parts ), 'SQL query does not contain correct number of OR operators.' );
 
         // Checking number of occurrences of AND while skipping the one at the beginning.
@@ -1280 +1280 @@
         $parts = mb_split( '\)\s+AND\s+\(', $sql );
         $this->assertIsArray( $parts, 'SQL query cannot be split into multiple parts using operator AND.' );
-        $this->assertEquals( 2, count( $parts ), 'SQL query does not contain correct number of AND operators.' );
+        $this->assertSame( 2, count( $parts ), 'SQL query does not contain correct number of AND operators.' );
 
         $this->assertStringNotContainsString( 'OR', $sql, 'SQL query contains conditions joined by operator OR.' );