Changeset 55467

Timestamp:

03/06/2023 04:27:23 PM (19 months ago)

Author:

hellofromTonya

Message:

Tests: Improve Tests_Media::test_wp_generate_attachment_metadata_doesnt_generate_sizes_for_150_square_image().

Changes:

• from assertEquals() to assertSame(). Why? To ensure both the return value and data type match the expected results.

• the expected height and width from string to integer data types. Why integer? getimagesize() (within wp_getimagesize()) will return an integer for both height and weight.

• adds the ticket annotation.

• adds assertion failure messages. Why? To denote which assertion failed, which aids in debugging efforts.

Follow-up to [55278].

Props costdev, peterwilsoncc, mukesh27, ankitmaru, hellofromTonya.
See #56800, #57370.

File:

• trunk/tests/phpunit/tests/media.php (modified) (2 diffs)

trunk/tests/phpunit/tests/media.php

@@ -3936 +3936 @@
     /**
      * Test that an image size isn't generated if it matches the original image size.
+     *
+     * @ticket 57370
      */
     public function test_wp_generate_attachment_metadata_doesnt_generate_sizes_for_150_square_image() {
@@ -3950 +3952 @@
 
         $metadata = wp_generate_attachment_metadata( $attachment_id, $file );
-        $this->assertEquals(
+        $this->assertSame(
             array(),
-            $metadata['sizes']
-        );
-        $this->assertEquals(
+            $metadata['sizes'],
+            'The sizes should be an empty array'
+        );
+        $this->assertSame(
             'test-square-150.jpg',
-            basename( $metadata['file'] )
-        );
-        $this->assertEquals(
-            '150',
-            $metadata['width']
-        );
-        $this->assertEquals(
-            '150',
-            $metadata['height']
+            basename( $metadata['file'] ),
+            'The file basename should match the given filename'
+        );
+        $this->assertSame(
+            150,
+            $metadata['width'],
+            'The width should be 150 (integer)'
+        );
+        $this->assertSame(
+            150,
+            $metadata['height'],
+            'The height should be 150 (integer)'
         );
     }