Changeset 55495 for trunk/tests/phpunit/tests/formatting/makeClickable.php

Timestamp:

03/09/2023 12:18:29 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Formatting: Restore consistent quotes in _make_web_ftp_clickable_cb().

After the introduction of _make_clickable_rel_attr() in an earlier commit, the function ended up returning link markup with a mix of single and double quotes.

This commit ensures that _make_web_ftp_clickable_cb() always returns double quotes, restoring consistency with other similar callback functions used by make_clickable():

• _make_url_clickable_cb()
• _make_email_clickable_cb()

Follow-up to [55289].

See #53290, #56444.

File:

• trunk/tests/phpunit/tests/formatting/makeClickable.php (modified) (4 diffs)

trunk/tests/phpunit/tests/formatting/makeClickable.php

@@ -109 +109 @@
         );
         $urls_expected = array(
-            "<a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>. Alice!",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>, said Alice.",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>; said Alice.",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>: said Alice.",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>) said Alice.",
+            '<a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>. Alice!',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>, said Alice.',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>; said Alice.',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>: said Alice.',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>) said Alice.',
         );
 
@@ -136 +136 @@
         );
         $urls_expected = array(
-            "<a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>.",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>,",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>;",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>:",
-            "There was a spoon named <a href='http://www.wordpress.org' rel=\"nofollow\">http://www.wordpress.org</a>)",
+            '<a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>.',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>,',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>;',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>:',
+            'There was a spoon named <a href="http://www.wordpress.org" rel="nofollow">http://www.wordpress.org</a>)',
         );
 
@@ -440 +440 @@
 
     public function data_add_rel_ugc_in_comments() {
-
         $home_url_http  = set_url_scheme( home_url(), 'http' );
         $home_url_https = set_url_scheme( home_url(), 'https' );
@@ -452 +451 @@
             array(
                 'www.wordpress.org',
-                '<p><a href=\'http://www.wordpress.org\' rel="nofollow ugc">http://www.wordpress.org</a>',
+                '<p><a href="http://www.wordpress.org" rel="nofollow ugc">http://www.wordpress.org</a>',
             ),
             // @ticket 56444
             array(
                 'www.example.org',
-                '<p><a href=\'http://www.example.org\' rel="nofollow ugc">http://www.example.org</a>',
+                '<p><a href="http://www.example.org" rel="nofollow ugc">http://www.example.org</a>',
             ),
             array(