Changeset 55558

Timestamp:

03/17/2023 03:56:01 PM (19 months ago)

Author:

spacedmonkey

Message:

Date / Time: Remove usage of mysql2date in generate_postdata method.

Remove usage of mysql2date in generate_postdata. mysql2date has a performance overhead, as it creates a DateTimeZone object each time it is called. Use a simple
sub string function to generate the values needed for the currentmonth and currentday global variables.

Props spacedmonkey, Rarst, SergeyBiryukov, flixos90.
Fixes #57683.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-query.php

@@ -4715 +4715 @@
         $authordata = get_userdata( $post->post_author );
 
-        $currentday   = mysql2date( 'd.m.y', $post->post_date, false );
-        $currentmonth = mysql2date( 'm', $post->post_date, false );
-        $numpages     = 1;
-        $multipage    = 0;
-        $page         = $this->get( 'page' );
+        $currentday   = false;
+        $currentmonth = false;
+
+        $post_date = $post->post_date;
+        if ( ! empty( $post_date ) && '0000-00-00 00:00:00' !== $post_date ) {
+            // Avoid using mysql2date for performance reasons.
+            $currentmonth = substr( $post_date, 5, 2 );
+            $day          = substr( $post_date, 8, 2 );
+            $year         = substr( $post_date, 2, 2 );
+
+            $currentday = sprintf( '%s.%s.%s', $day, $currentmonth, $year );
+        }
+
+        $numpages  = 1;
+        $multipage = 0;
+        $page      = $this->get( 'page' );
         if ( ! $page ) {
             $page = 1;