Changeset 55559

Timestamp:

03/18/2023 12:32:54 PM (19 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove unused variables in WP_Comment_Query.

• $unapproved_ids and $unapproved_emails in WP_Comment_Query::get_comment_ids() were added in [29965] and appear to never have been used.
• $wpdb in WP_Comment_Query::fill_descendants() was replaced with $this->db in [38275], removed in [38446], and accidentally reinstated in [38768].

Follow-up to [29965], [34546], [37625], [38275], [38446], [38768], [44546].

Props upadalavipul, dingo_d, audrasjb, SergeyBiryukov.
Fixes #57482.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -585 +585 @@
             $include_unapproved = wp_parse_list( $this->query_vars['include_unapproved'] );
 
-            $unapproved_ids    = array();
-            $unapproved_emails = array();
             foreach ( $include_unapproved as $unapproved_identifier ) {
                 // Numeric values are assumed to be user IDs.
@@ -1014 +1012 @@
      * @since 4.4.0
      *
-     * @global wpdb $wpdb WordPress database abstraction object.
-     *
      * @param WP_Comment[] $comments Array of top-level comments whose descendants should be filled in.
      * @return array
      */
     protected function fill_descendants( $comments ) {
-        global $wpdb;
-
         $levels = array(
             0 => wp_list_pluck( $comments, 'comment_ID' ),