Changeset 55562 for trunk/tests/phpunit/tests/formatting/seemsUtf8.php

Timestamp:

03/19/2023 12:03:30 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use the data_ prefix for various data provider methods.

This aims to bring more consistency to the test suite, as the vast majority of data providers already use that prefix.

Includes moving some data providers next to the tests they are used in.

Follow-up to [55464].

See #57841.

File:

• trunk/tests/phpunit/tests/formatting/seemsUtf8.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/seemsUtf8.php

@@ -11 +11 @@
          * `seems_utf8` returns true for utf-8 strings, false otherwise.
          *
-         * @dataProvider utf8_strings
+         * @dataProvider data_seems_utf8_returns_true_for_utf8_strings
          */
-        public function test_returns_true_for_utf8_strings( $utf8_string ) {
+        public function test_seems_utf8_returns_true_for_utf8_strings( $utf8_string ) {
                 // From http://www.i18nguy.com/unicode-example.html
                 $this->assertTrue( seems_utf8( $utf8_string ) );
         }
 
-        public function utf8_strings() {
+        public function data_seems_utf8_returns_true_for_utf8_strings() {
                 $utf8_strings = file( DIR_TESTDATA . '/formatting/utf-8/utf-8.txt' );
                 foreach ( $utf8_strings as &$string ) {
@@ -28 +28 @@
 
         /**
-         * @dataProvider big5_strings
+         * @dataProvider data_seems_utf8_returns_false_for_non_utf8_strings
          */
-        public function test_returns_false_for_non_utf8_strings( $big5_string ) {
+        public function test_seems_utf8_returns_false_for_non_utf8_strings( $big5_string ) {
                 $this->assertFalse( seems_utf8( $big5_string ) );
         }
 
-        public function big5_strings() {
+        public function data_seems_utf8_returns_false_for_non_utf8_strings() {
                 // Get data from formatting/big5.txt.
                 $big5_strings = file( DIR_TESTDATA . '/formatting/big5.txt' );