Changeset 55562 for trunk/tests/phpunit/tests/option/sanitizeOption.php

Timestamp:

03/19/2023 12:03:30 PM (19 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use the data_ prefix for various data provider methods.

This aims to bring more consistency to the test suite, as the vast majority of data providers already use that prefix.

Includes moving some data providers next to the tests they are used in.

Follow-up to [55464].

See #57841.

File:

• trunk/tests/phpunit/tests/option/sanitizeOption.php (modified) (6 diffs)

trunk/tests/phpunit/tests/option/sanitizeOption.php

@@ -7 +7 @@
 
     /**
+     * @dataProvider data_sanitize_option
+     *
+     * @covers ::sanitize_option
+     */
+    public function test_sanitize_option( $option_name, $sanitized, $original ) {
+        $this->assertSame( $sanitized, sanitize_option( $option_name, $original ) );
+    }
+    /**
      * Data provider to test all of the sanitize_option() case
      *
@@ -13 +21 @@
      * @return array
      */
-    public function sanitize_option_provider() {
+    public function data_sanitize_option() {
         return array(
             array( 'admin_email', 'mail@example.com', 'mail@example.com' ),
@@ -87 +95 @@
 
     /**
-     * @dataProvider sanitize_option_provider
+     * @dataProvider data_sanitize_option_upload_path
      *
      * @covers ::sanitize_option
      */
-    public function test_sanitize_option( $option_name, $sanitized, $original ) {
-        $this->assertSame( $sanitized, sanitize_option( $option_name, $original ) );
+    public function test_sanitize_option_upload_path( $provided, $expected ) {
+        $this->assertSame( $expected, sanitize_option( 'upload_path', $provided ) );
     }
 
-    public function upload_path_provider() {
+    public function data_sanitize_option_upload_path() {
         return array(
             array( '<a href="http://www.example.com">Link</a>', 'Link' ),
@@ -102 +110 @@
             array( '\path\to\things', '\path\to\things' ),
         );
-    }
-
-    /**
-     * @dataProvider upload_path_provider
-     *
-     * @covers ::sanitize_option
-     */
-    public function test_sanitize_option_upload_path( $provided, $expected ) {
-        $this->assertSame( $expected, sanitize_option( 'upload_path', $provided ) );
     }
 
@@ -134 +133 @@
 
     /**
-     * @dataProvider permalink_structure_provider
+     * @dataProvider data_sanitize_option_permalink_structure
      *
      * @covers ::sanitize_option
      * @covers ::get_settings_errors
      */
-    public function test_sanitize_permalink_structure( $provided, $expected, $valid ) {
+    public function test_sanitize_option_permalink_structure( $provided, $expected, $valid ) {
         global $wp_settings_errors;
 
@@ -160 +159 @@
     }
 
-    public function permalink_structure_provider() {
+    public function data_sanitize_option_permalink_structure() {
         return array(
             array( '', '', true ),