Changeset 55562 for trunk/tests/phpunit/tests/post/nav-menu.php

Timestamp:

03/19/2023 12:03:30 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use the data_ prefix for various data provider methods.

This aims to bring more consistency to the test suite, as the vast majority of data providers already use that prefix.

Includes moving some data providers next to the tests they are used in.

Follow-up to [55464].

See #57841.

File:

• trunk/tests/phpunit/tests/post/nav-menu.php (modified) (2 diffs)

trunk/tests/phpunit/tests/post/nav-menu.php

@@ -967 +967 @@
 
         /**
+         * @ticket 43401
+         * @dataProvider data_iri_current_menu_item
+         */
+        public function test_iri_current_menu_item( $custom_link, $current = true ) {
+                wp_update_nav_menu_item(
+                        $this->menu_id,
+                        0,
+                        array(
+                                'menu-item-status' => 'publish',
+                                'menu-item-type'   => 'custom',
+                                'menu-item-url'    => $custom_link,
+                        )
+                );
+
+                $this->go_to( site_url( '/%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82/' ) );
+
+                $menu_items = wp_get_nav_menu_items( $this->menu_id );
+                _wp_menu_item_classes_by_context( $menu_items );
+
+                $classes = $menu_items[0]->classes;
+
+                if ( $current ) {
+                        $this->assertContains( 'current-menu-item', $classes );
+                } else {
+                        $this->assertNotContains( 'current-menu-item', $classes );
+                }
+        }
+
+        /**
          * Provides IRI matching data for _wp_menu_item_classes_by_context() test.
          */
-        public function get_iri_current_menu_items() {
+        public function data_iri_current_menu_item() {
                 return array(
                         array( site_url( '/%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82/' ) ),
@@ -981 +1010 @@
 
         /**
-         * @ticket 43401
-         * @dataProvider get_iri_current_menu_items
-         */
-        public function test_iri_current_menu_item( $custom_link, $current = true ) {
-                wp_update_nav_menu_item(
-                        $this->menu_id,
-                        0,
-                        array(
-                                'menu-item-status' => 'publish',
-                                'menu-item-type'   => 'custom',
-                                'menu-item-url'    => $custom_link,
-                        )
-                );
-
-                $this->go_to( site_url( '/%D0%BF%D1%80%D0%B8%D0%B2%D0%B5%D1%82/' ) );
-
-                $menu_items = wp_get_nav_menu_items( $this->menu_id );
-                _wp_menu_item_classes_by_context( $menu_items );
-
-                $classes = $menu_items[0]->classes;
-
-                if ( $current ) {
-                        $this->assertContains( 'current-menu-item', $classes );
-                } else {
-                        $this->assertNotContains( 'current-menu-item', $classes );
-                }
-        }
-
-        /**
          * @ticket 44005
          * @group privacy