Changeset 55562 for trunk/tests/phpunit/tests/post/query.php

Timestamp:

03/19/2023 12:03:30 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use the data_ prefix for various data provider methods.

This aims to bring more consistency to the test suite, as the vast majority of data providers already use that prefix.

Includes moving some data providers next to the tests they are used in.

Follow-up to [55464].

See #57841.

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (2 diffs)

trunk/tests/phpunit/tests/post/query.php

@@ -713 +713 @@
     }
 
-    public function set_found_posts_provider() {
+    /**
+     * @ticket 42860
+     *
+     * @dataProvider data_set_found_posts_not_posts_as_an_array
+     */
+    public function test_set_found_posts_not_posts_as_an_array( $posts, $expected ) {
+        $q = new WP_Query(
+            array(
+                'post_type'      => 'wptests_pt',
+                'posts_per_page' => 1,
+            )
+        );
+
+        $q->posts = $posts;
+
+        $methd = new ReflectionMethod( 'WP_Query', 'set_found_posts' );
+        $methd->setAccessible( true );
+        $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
+
+        $this->assertSame( $expected, $q->found_posts );
+    }
+
+    public function data_set_found_posts_not_posts_as_an_array() {
         // Count return 0 for null, but 1 for other data you may not expect.
         return array(
@@ -724 +746 @@
 
     /**
-     * @ticket 42860
-     *
-     * @dataProvider set_found_posts_provider
-     */
-    public function test_set_found_posts_not_posts_as_an_array( $posts, $expected ) {
-        $q = new WP_Query(
-            array(
-                'post_type'      => 'wptests_pt',
-                'posts_per_page' => 1,
-            )
-        );
-
-        $q->posts = $posts;
-
-        $methd = new ReflectionMethod( 'WP_Query', 'set_found_posts' );
-        $methd->setAccessible( true );
-        $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
-
-        $this->assertSame( $expected, $q->found_posts );
-    }
-
-    /**
      * @ticket 42469
      */