Changeset 55562 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

03/19/2023 12:03:30 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use the data_ prefix for various data provider methods.

This aims to bring more consistency to the test suite, as the vast majority of data providers already use that prefix.

Includes moving some data providers next to the tests they are used in.

Follow-up to [55464].

See #57841.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (5 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -2358 +2358 @@
     }
 
-    public function post_dates_provider() {
+    public function data_post_dates() {
         $all_statuses = array(
             'draft',
@@ -2429 +2429 @@
 
     /**
-     * @dataProvider post_dates_provider
+     * @dataProvider data_post_dates
      */
     public function test_create_post_date( $status, $params, $results ) {
@@ -3478 +3478 @@
 
     /**
-     * @dataProvider post_dates_provider
+     * @dataProvider data_post_dates
      */
     public function test_update_post_date( $status, $params, $results ) {
@@ -4033 +4033 @@
     }
 
-    public static function post_roundtrip_provider() {
+    /**
+     * @dataProvider data_post_roundtrip_as_author
+     */
+    public function test_post_roundtrip_as_author( $raw, $expected ) {
+        wp_set_current_user( self::$author_id );
+
+        $this->assertFalse( current_user_can( 'unfiltered_html' ) );
+        $this->verify_post_roundtrip( $raw, $expected );
+    }
+
+    public static function data_post_roundtrip_as_author() {
         return array(
             array(
@@ -4128 +4138 @@
             ),
         );
-    }
-
-    /**
-     * @dataProvider post_roundtrip_provider
-     */
-    public function test_post_roundtrip_as_author( $raw, $expected ) {
-        wp_set_current_user( self::$author_id );
-
-        $this->assertFalse( current_user_can( 'unfiltered_html' ) );
-        $this->verify_post_roundtrip( $raw, $expected );
     }