Changeset 55563 for trunk/tests/phpunit/tests/formatting/urlencodeDeep.php

Timestamp:

03/19/2023 12:51:14 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Improve documentation and variable names in some formatting tests.

Includes documenting data provider values using hash notation in the tests for:

• convert_smilies()
• get_url_in_content()
• links_add_target()
• normalize_whitespace()

Follow-up to [26191], [26327], [26328], [26972], [55562].

See #57841.

File:

• trunk/tests/phpunit/tests/formatting/urlencodeDeep.php (modified) (2 diffs)

trunk/tests/phpunit/tests/formatting/urlencodeDeep.php

@@ -10 +10 @@
 
     /**
-     * Data Provider
+     * Tests the urlencode_deep() function pair by pair.
+     *
+     * @dataProvider data_urlencode_deep
+     *
+     * @param string $input
+     * @param string $expected
+     */
+    public function test_urlencode_deep_should_encode_individual_value( $input, $expected ) {
+        $this->assertSame( $expected, urlencode_deep( $input ) );
+    }
+
+    /**
+     * Data provider.
      */
     public function data_urlencode_deep() {
@@ -23 +35 @@
 
     /**
-     * Validate the urlencode_deep function pair by pair
-     *
-     * @dataProvider data_urlencode_deep
-     *
-     * @param string $actual
-     * @param string $expected
-     */
-    public function test_urlencode_deep_should_encode_individual_value( $actual, $expected ) {
-        $this->assertSame( $expected, urlencode_deep( $actual ) );
-    }
-
-    /**
-     * Test the whole array as input
+     * Tests the whole array as input.
      */
     public function test_urlencode_deep_should_encode_all_values_in_array() {