Changeset 55577 for trunk/tests/phpunit/includes/object-cache.php

Timestamp:

03/21/2023 05:00:21 PM (19 months ago)

Author:

spacedmonkey

Message:

Build/Test Tools: Fix issue with add method in object-cache.php.

In the object-cache.php file used for unit tests, the add method did not work as expected. Other object cache plugins and core, have a check to see if the key exists in memory before writing it. Without this check, it used to write unnecessarily to the cache.

Props spacedmonkey, SergeyBiryukov.
Fixes #57963.

File:

• trunk/tests/phpunit/includes/object-cache.php (modified) (1 diff)

trunk/tests/phpunit/includes/object-cache.php

@@ -978 +978 @@
 
         $derived_key = $this->buildKey( $key, $group );
-        $expiration  = $this->sanitize_expiration( $expiration );
+
+        // Add does not set the value if the key exists; mimic that here.
+        if ( isset( $this->cache[ $derived_key ] ) ) {
+            return false;
+        }
 
         // If group is a non-Memcached group, save to runtime cache, not Memcached.
         if ( in_array( $group, $this->no_mc_groups, true ) ) {
 
-            // Add does not set the value if the key exists; mimic that here.
-            if ( isset( $this->cache[ $derived_key ] ) ) {
-                return false;
-            }
-
             $this->add_to_internal_cache( $derived_key, $value );
 
             return true;
         }
+
+        $expiration = $this->sanitize_expiration( $expiration );
 
         // Save to Memcached.