Changeset 55592

Timestamp:

03/25/2023 03:23:41 PM (18 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/user.php.

Follow-up to [10990], [11162], [11217], [37059].

Props jenilk.
Fixes #57317.

File:

• trunk/src/wp-admin/includes/user.php (modified) (5 diffs)

trunk/src/wp-admin/includes/user.php

@@ -180 +180 @@
 
     // Checking the password has been typed twice the same.
-    if ( ( $update || ! empty( $pass1 ) ) && $pass1 != $pass2 ) {
+    if ( ( $update || ! empty( $pass1 ) ) && $pass1 !== $pass2 ) {
         $errors->add( 'pass', __( '<strong>Error:</strong> Passwords do not match. Please enter the same password in both password fields.' ), array( 'form-field' => 'pass1' ) );
     }
@@ -203 +203 @@
     }
 
-    /* checking email address */
+    // Checking email address.
     if ( empty( $user->user_email ) ) {
         $errors->add( 'empty_email', __( '<strong>Error:</strong> Please enter an email address.' ), array( 'form-field' => 'email' ) );
@@ -210 +210 @@
     } else {
         $owner_id = email_exists( $user->user_email );
-        if ( $owner_id && ( ! $update || ( $owner_id != $user->ID ) ) ) {
+        if ( $owner_id && ( ! $update || ( $owner_id !== $user->ID ) ) ) {
             $errors->add( 'email_exists', __( '<strong>Error:</strong> This email is already registered. Please choose another one.' ), array( 'form-field' => 'email' ) );
         }
@@ -486 +486 @@
     // get_user_setting() = JS-saved UI setting. Else no-js-fallback code.
     if ( 'hide' === get_user_setting( 'default_password_nag' )
-        || isset( $_GET['default_password_nag'] ) && '0' == $_GET['default_password_nag']
+        || isset( $_GET['default_password_nag'] ) && '0' === $_GET['default_password_nag']
     ) {
         delete_user_setting( 'default_password_nag' );
@@ -508 +508 @@
 
     // Remove the nag if the password has been changed.
-    if ( $new_data->user_pass != $old_data->user_pass ) {
+    if ( $new_data->user_pass !== $old_data->user_pass ) {
         delete_user_setting( 'default_password_nag' );
         update_user_meta( $user_ID, 'default_password_nag', false );