Changeset 55593

Timestamp:

03/26/2023 10:04:40 AM (19 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/nav-menu.php.

Follow-up to [14248], [15008], [37748].

Props jenilk, johnbillion.
Fixes #57318.

File:

• trunk/src/wp-admin/includes/nav-menu.php (modified) (4 diffs)

trunk/src/wp-admin/includes/nav-menu.php

@@ -939 +939 @@
     $items_saved = array();
 
-    if ( 0 == $menu_id || is_nav_menu( $menu_id ) ) {
+    if ( 0 === $menu_id || is_nav_menu( $menu_id ) ) {
 
         // Loop through all the menu items' POST values.
@@ -965 +965 @@
                 empty( $_item_object_data['menu-item-db-id'] ) ||
                 ( 0 > $_possible_db_id ) ||
-                $_possible_db_id != $_item_object_data['menu-item-db-id']
+                $_possible_db_id !== (int) $_item_object_data['menu-item-db-id']
             ) {
                 $_actual_db_id = 0;
@@ -1212 +1212 @@
             }
 
-            $menu_item_db_id = wp_update_nav_menu_item( $nav_menu_selected_id, ( $_POST['menu-item-db-id'][ $_key ] != $_key ? 0 : $_key ), $args );
+            $menu_item_db_id = wp_update_nav_menu_item(
+                $nav_menu_selected_id,
+                ( (int) $_POST['menu-item-db-id'][ $_key ] !== $_key ? 0 : $_key ),
+                $arg
+            );
 
             if ( is_wp_error( $menu_item_db_id ) ) {
@@ -1302 +1306 @@
             // Build the new array value from leaf to trunk.
             for ( $i = count( $array_bits ) - 1; $i >= 0; $i-- ) {
-                if ( count( $array_bits ) - 1 == $i ) {
+                if ( count( $array_bits ) - 1 === $i ) {
                     $new_post_data[ $array_bits[ $i ] ] = wp_slash( $post_input_data->value );
                 } else {