Changeset 55608 for trunk/tests/phpunit/tests/query/lazyLoadTermMeta.php

Timestamp:

03/29/2023 10:48:34 AM (3 years ago)

Author:

spacedmonkey

Message:

Options, Meta APIs: Improve the lazy loading meta API to include current object id.

The existing lazy loading meta api, creates a queue of ids, to be primed, if the get_comment_meta or get_term_meta functions are called. However, it did not check to see if the requested id was in the queue, before prime all the ids in the queue. Now, it adds the id to the queue, is not already in the queue, saving a cache lookup / database query.

Props spacedmonkey, peterwilsoncc, mukesh27, flixos90.
Fixes #57901.

File:

• trunk/tests/phpunit/tests/query/lazyLoadTermMeta.php (modified) (2 diffs)

trunk/tests/phpunit/tests/query/lazyLoadTermMeta.php

@@ -109 +109 @@
         }
 
+
+        /**
+         * @ticket 57901
+         *
+         * @covers ::wp_queue_posts_for_term_meta_lazyload
+         */
+        public function test_wp_queue_posts_for_term_meta_lazyload_insert_term() {
+                $filter = new MockAction();
+                add_filter( 'update_term_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $t1      = wp_insert_term( 'Foo', 'wptests_tax' );
+                $term_id = $t1['term_id'];
+
+                new WP_Query(
+                        array(
+                                'post__in'            => self::$post_ids,
+                                'lazy_load_term_meta' => true,
+                        )
+                );
+
+                get_term_meta( $term_id );
+
+                $args     = $filter->get_args();
+                $first    = reset( $args );
+                $term_ids = end( $first );
+                $this->assertContains( $term_id, $term_ids );
+        }
+
         /**
          * @ticket 57150
@@ -134 +164 @@
                 $first    = reset( $args );
                 $term_ids = end( $first );
-                $this->assertNotContains( $remove_term_id, $term_ids );
+                $this->assertContains( $remove_term_id, $term_ids );
         }
 }