Changeset 55633

Timestamp:

04/08/2023 09:03:08 AM (19 months ago)

Author:

SergeyBiryukov

Message:

Twenty Twenty-One: Replace include_once with require_once for required classes.

Per ​WordPress PHP coding standards, it is strongly recommended to use require[_once] for unconditional includes. When using include[_once], PHP will throw a warning when the file is not found but will continue execution, which will almost certainly lead to other errors/warnings/notices being thrown if your application depends on the file loaded, potentially leading to security leaks. For that reason, require[_once] is generally the better choice as it will throw a Fatal Error if the file cannot be found.

Follow-up to [49216], [49633].

Props wpfy.
See #57839.

Location:

trunk/src/wp-content/themes/twentytwentyone/classes

Files:

• class-twenty-twenty-one-customize.php (modified) (1 diff)
• class-twenty-twenty-one-dark-mode.php (modified) (1 diff)

trunk/src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-customize.php

@@ -114 +114 @@
             // Background color.
             // Include the custom control class.
-            include_once get_theme_file_path( 'classes/class-twenty-twenty-one-customize-color-control.php' ); // phpcs:ignore WPThemeReview.CoreFunctionality.FileInclude.FileIncludeFound
+            require_once get_theme_file_path( 'classes/class-twenty-twenty-one-customize-color-control.php' ); // phpcs:ignore WPThemeReview.CoreFunctionality.FileInclude.FileIncludeFound
 
             // Register the custom control.

trunk/src/wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-dark-mode.php

@@ -136 +136 @@
 
         // Custom notice control.
-        include_once get_theme_file_path( 'classes/class-twenty-twenty-one-customize-notice-control.php' ); // phpcs:ignore WPThemeReview.CoreFunctionality.FileInclude.FileIncludeFound
+        require_once get_theme_file_path( 'classes/class-twenty-twenty-one-customize-notice-control.php' ); // phpcs:ignore WPThemeReview.CoreFunctionality.FileInclude.FileIncludeFound
 
         $wp_customize->add_setting(