Changeset 55641

Timestamp:

04/09/2023 11:55:37 AM (19 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Replace include_once with require_once for required files.

Per ​WordPress PHP coding standards, it is strongly recommended to use require[_once] for unconditional includes. When using include[_once], PHP will throw a warning when the file is not found but will continue execution, which will almost certainly lead to other errors/warnings/notices being thrown if your application depends on the file loaded, potentially leading to security leaks. For that reason, require[_once] is generally the better choice as it will throw a Fatal Error if the file cannot be found.

Follow-up to [1674], [1812], [1964], [6779], [8540], [10521], [11005], [11911], [16065], [16149], [25421], [25466], [25823], [37714], [42981], [45448], [47198], [54276], [55633].

Props kausaralm, SergeyBiryukov.
See #57839.

Location:

trunk/src

Files:

• wp-admin/includes/ajax-actions.php (modified) (5 diffs)
• wp-admin/includes/class-wp-filesystem-ftpsockets.php (modified) (1 diff)
• wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (1 diff)
• wp-admin/includes/upgrade.php (modified) (1 diff)
• wp-admin/privacy-policy-guide.php (modified) (1 diff)
• wp-admin/update.php (modified) (2 diffs)
• wp-includes/blocks.php (modified) (1 diff)
• wp-includes/comment.php (modified) (2 diffs)
• wp-includes/cron.php (modified) (1 diff)
• wp-includes/functions.php (modified) (1 diff)
• wp-includes/update.php (modified) (1 diff)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -246 +246 @@
     check_ajax_referer( "image_editor-$post_id" );
 
-    include_once ABSPATH . 'wp-admin/includes/image-edit.php';
+    require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
     if ( ! stream_preview_image( $post_id ) ) {
@@ -2650 +2650 @@
 
     check_ajax_referer( "image_editor-$attachment_id" );
-    include_once ABSPATH . 'wp-admin/includes/image-edit.php';
+    require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
     $msg = false;
@@ -4158 +4158 @@
 
     require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
-    include_once ABSPATH . 'wp-admin/includes/theme.php';
+    require_once ABSPATH . 'wp-admin/includes/theme.php';
 
     $api = themes_api(
@@ -4403 +4403 @@
     }
 
-    include_once ABSPATH . 'wp-admin/includes/theme.php';
+    require_once ABSPATH . 'wp-admin/includes/theme.php';
 
     $result = delete_theme( $stylesheet );
@@ -4451 +4451 @@
 
     require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
-    include_once ABSPATH . 'wp-admin/includes/plugin-install.php';
+    require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 
     $api = plugins_api(

trunk/src/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -34 +34 @@
 
         // Check if possible to use ftp functions.
-        if ( ! include_once ABSPATH . 'wp-admin/includes/class-ftp.php' ) {
+        if ( ! require_once ABSPATH . 'wp-admin/includes/class-ftp.php' ) {
             return;
         }

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -89 +89 @@
      */
     public function prepare_items() {
-        include_once ABSPATH . 'wp-admin/includes/plugin-install.php';
+        require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 
         global $tabs, $tab, $paged, $type, $term;

trunk/src/wp-admin/includes/upgrade.php

@@ -352 +352 @@
         } else {
             if ( ! class_exists( 'WP_Privacy_Policy_Content' ) ) {
-                include_once ABSPATH . 'wp-admin/includes/class-wp-privacy-policy-content.php';
+                require_once ABSPATH . 'wp-admin/includes/class-wp-privacy-policy-content.php';
             }
 

trunk/src/wp-admin/privacy-policy-guide.php

@@ -15 +15 @@
 
 if ( ! class_exists( 'WP_Privacy_Policy_Content' ) ) {
-    include_once ABSPATH . 'wp-admin/includes/class-wp-privacy-policy-content.php';
+    require_once ABSPATH . 'wp-admin/includes/class-wp-privacy-policy-content.php';
 }
 

trunk/src/wp-admin/update.php

@@ -108 +108 @@
         }
 
-        include_once ABSPATH . 'wp-admin/includes/plugin-install.php'; // For plugins_api().
+        require_once ABSPATH . 'wp-admin/includes/plugin-install.php'; // For plugins_api().
 
         check_admin_referer( 'install-plugin_' . $plugin );
@@ -259 +259 @@
         }
 
-        include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php'; // For themes_api().
+        require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php'; // For themes_api().
 
         check_admin_referer( 'install-theme_' . $theme );

trunk/src/wp-includes/blocks.php

@@ -319 +319 @@
     static $core_blocks_meta;
     if ( ! $core_blocks_meta ) {
-        $core_blocks_meta = include_once ABSPATH . WPINC . '/blocks/blocks-json.php';
+        $core_blocks_meta = require_once ABSPATH . WPINC . '/blocks/blocks-json.php';
     }
 

trunk/src/wp-includes/comment.php

@@ -3052 +3052 @@
  */
 function pingback( $content, $post ) {
-    include_once ABSPATH . WPINC . '/class-IXR.php';
-    include_once ABSPATH . WPINC . '/class-wp-http-ixr-client.php';
+    require_once ABSPATH . WPINC . '/class-IXR.php';
+    require_once ABSPATH . WPINC . '/class-wp-http-ixr-client.php';
 
     // Original code by Mort (http://mort.mine.nu:8080).
@@ -3219 +3219 @@
  */
 function weblog_ping( $server = '', $path = '' ) {
-    include_once ABSPATH . WPINC . '/class-IXR.php';
-    include_once ABSPATH . WPINC . '/class-wp-http-ixr-client.php';
+    require_once ABSPATH . WPINC . '/class-IXR.php';
+    require_once ABSPATH . WPINC . '/class-wp-http-ixr-client.php';
 
     // Using a timeout of 3 seconds should be enough to cover slow servers.

trunk/src/wp-includes/cron.php

@@ -884 +884 @@
         flush();
 
-        include_once ABSPATH . 'wp-cron.php';
+        require_once ABSPATH . 'wp-cron.php';
         return true;
     }

trunk/src/wp-includes/functions.php

@@ -883 +883 @@
 
     // @todo Tidy this code and make the debug code optional.
-    include_once ABSPATH . WPINC . '/class-IXR.php';
+    require_once ABSPATH . WPINC . '/class-IXR.php';
 
     $post = get_post( $post );

trunk/src/wp-includes/update.php

@@ -844 +844 @@
  */
 function wp_maybe_auto_update() {
-    include_once ABSPATH . 'wp-admin/includes/admin.php';
+    require_once ABSPATH . 'wp-admin/includes/admin.php';
     require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';