Changeset 55641 for trunk/src/wp-admin/includes/ajax-actions.php

Timestamp:

04/09/2023 11:55:37 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Replace include_once with require_once for required files.

Per ​WordPress PHP coding standards, it is strongly recommended to use require[_once] for unconditional includes. When using include[_once], PHP will throw a warning when the file is not found but will continue execution, which will almost certainly lead to other errors/warnings/notices being thrown if your application depends on the file loaded, potentially leading to security leaks. For that reason, require[_once] is generally the better choice as it will throw a Fatal Error if the file cannot be found.

Follow-up to [1674], [1812], [1964], [6779], [8540], [10521], [11005], [11911], [16065], [16149], [25421], [25466], [25823], [37714], [42981], [45448], [47198], [54276], [55633].

Props kausaralm, SergeyBiryukov.
See #57839.

File:

• trunk/src/wp-admin/includes/ajax-actions.php (modified) (5 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -246 +246 @@
         check_ajax_referer( "image_editor-$post_id" );
 
-        include_once ABSPATH . 'wp-admin/includes/image-edit.php';
+        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
         if ( ! stream_preview_image( $post_id ) ) {
@@ -2650 +2650 @@
 
         check_ajax_referer( "image_editor-$attachment_id" );
-        include_once ABSPATH . 'wp-admin/includes/image-edit.php';
+        require_once ABSPATH . 'wp-admin/includes/image-edit.php';
 
         $msg = false;
@@ -4158 +4158 @@
 
         require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
-        include_once ABSPATH . 'wp-admin/includes/theme.php';
+        require_once ABSPATH . 'wp-admin/includes/theme.php';
 
         $api = themes_api(
@@ -4403 +4403 @@
         }
 
-        include_once ABSPATH . 'wp-admin/includes/theme.php';
+        require_once ABSPATH . 'wp-admin/includes/theme.php';
 
         $result = delete_theme( $stylesheet );
@@ -4451 +4451 @@
 
         require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
-        include_once ABSPATH . 'wp-admin/includes/plugin-install.php';
+        require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 
         $api = plugins_api(