Make WordPress Core


Ignore:
Timestamp:
04/09/2023 11:55:37 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Coding Standards: Replace include_once with require_once for required files.

Per WordPress PHP coding standards, it is strongly recommended to use require[_once] for unconditional includes. When using include[_once], PHP will throw a warning when the file is not found but will continue execution, which will almost certainly lead to other errors/warnings/notices being thrown if your application depends on the file loaded, potentially leading to security leaks. For that reason, require[_once] is generally the better choice as it will throw a Fatal Error if the file cannot be found.

Follow-up to [1674], [1812], [1964], [6779], [8540], [10521], [11005], [11911], [16065], [16149], [25421], [25466], [25823], [37714], [42981], [45448], [47198], [54276], [55633].

Props kausaralm, SergeyBiryukov.
See #57839.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/ajax-actions.php

    r55474 r55641  
    246246    check_ajax_referer( "image_editor-$post_id" );
    247247
    248     include_once ABSPATH . 'wp-admin/includes/image-edit.php';
     248    require_once ABSPATH . 'wp-admin/includes/image-edit.php';
    249249
    250250    if ( ! stream_preview_image( $post_id ) ) {
     
    26502650
    26512651    check_ajax_referer( "image_editor-$attachment_id" );
    2652     include_once ABSPATH . 'wp-admin/includes/image-edit.php';
     2652    require_once ABSPATH . 'wp-admin/includes/image-edit.php';
    26532653
    26542654    $msg = false;
     
    41584158
    41594159    require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
    4160     include_once ABSPATH . 'wp-admin/includes/theme.php';
     4160    require_once ABSPATH . 'wp-admin/includes/theme.php';
    41614161
    41624162    $api = themes_api(
     
    44034403    }
    44044404
    4405     include_once ABSPATH . 'wp-admin/includes/theme.php';
     4405    require_once ABSPATH . 'wp-admin/includes/theme.php';
    44064406
    44074407    $result = delete_theme( $stylesheet );
     
    44514451
    44524452    require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
    4453     include_once ABSPATH . 'wp-admin/includes/plugin-install.php';
     4453    require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
    44544454
    44554455    $api = plugins_api(
Note: See TracChangeset for help on using the changeset viewer.