Changeset 55641 for trunk/src/wp-admin/update.php

Timestamp:

04/09/2023 11:55:37 AM (17 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Replace include_once with require_once for required files.

Per ​WordPress PHP coding standards, it is strongly recommended to use require[_once] for unconditional includes. When using include[_once], PHP will throw a warning when the file is not found but will continue execution, which will almost certainly lead to other errors/warnings/notices being thrown if your application depends on the file loaded, potentially leading to security leaks. For that reason, require[_once] is generally the better choice as it will throw a Fatal Error if the file cannot be found.

Follow-up to [1674], [1812], [1964], [6779], [8540], [10521], [11005], [11911], [16065], [16149], [25421], [25466], [25823], [37714], [42981], [45448], [47198], [54276], [55633].

Props kausaralm, SergeyBiryukov.
See #57839.

File:

• trunk/src/wp-admin/update.php (modified) (2 diffs)

trunk/src/wp-admin/update.php

@@ -108 +108 @@
         }
 
-        include_once ABSPATH . 'wp-admin/includes/plugin-install.php'; // For plugins_api().
+        require_once ABSPATH . 'wp-admin/includes/plugin-install.php'; // For plugins_api().
 
         check_admin_referer( 'install-plugin_' . $plugin );
@@ -259 +259 @@
         }
 
-        include_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php'; // For themes_api().
+        require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php'; // For themes_api().
 
         check_admin_referer( 'install-theme_' . $theme );