Changeset 55648

Timestamp:

04/12/2023 09:41:21 AM (17 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Rename the $qtInit and $mceInit variables in _WP_Editors.

This resolves 37 WPCS warnings along the lines of:

Variable "$qtInit" is not in valid snake_case format, try "$qt_init"
Variable "$mceInit" is not in valid snake_case format, try "$mce_init"

Follow-up to [18498].

See #57839.

File:

• trunk/src/wp-includes/class-wp-editor.php (modified) (9 diffs)

trunk/src/wp-includes/class-wp-editor.php

@@ -330 +330 @@
         if ( self::$this_quicktags ) {
 
-            $qtInit = array(
+            $qt_init = array(
                 'id'      => $editor_id,
                 'buttons' => '',
@@ -336 +336 @@
 
             if ( is_array( $set['quicktags'] ) ) {
-                $qtInit = array_merge( $qtInit, $set['quicktags'] );
-            }
-
-            if ( empty( $qtInit['buttons'] ) ) {
-                $qtInit['buttons'] = 'strong,em,link,block,del,ins,img,ul,ol,li,code,more,close';
+                $qt_init = array_merge( $qt_init, $set['quicktags'] );
+            }
+
+            if ( empty( $qt_init['buttons'] ) ) {
+                $qt_init['buttons'] = 'strong,em,link,block,del,ins,img,ul,ol,li,code,more,close';
             }
 
             if ( $set['_content_editor_dfw'] ) {
-                $qtInit['buttons'] .= ',dfw';
+                $qt_init['buttons'] .= ',dfw';
             }
 
@@ -352 +352 @@
              * @since 3.3.0
              *
-             * @param array  $qtInit    Quicktags settings.
+             * @param array  $qt_init   Quicktags settings.
              * @param string $editor_id Unique editor identifier, e.g. 'content'.
              */
-            $qtInit = apply_filters( 'quicktags_settings', $qtInit, $editor_id );
-
-            self::$qt_settings[ $editor_id ] = $qtInit;
-
-            self::$qt_buttons = array_merge( self::$qt_buttons, explode( ',', $qtInit['buttons'] ) );
+            $qt_init = apply_filters( 'quicktags_settings', $qt_init, $editor_id );
+
+            self::$qt_settings[ $editor_id ] = $qt_init;
+
+            self::$qt_buttons = array_merge( self::$qt_buttons, explode( ',', $qt_init['buttons'] ) );
         }
 
@@ -754 +754 @@
             }
 
-            $mceInit = array(
+            $mce_init = array(
                 'selector'          => "#$editor_id",
                 'wpautop'           => (bool) $set['wpautop'],
@@ -767 +767 @@
 
             // Merge with the first part of the init array.
-            $mceInit = array_merge( self::$first_init, $mceInit );
+            $mce_init = array_merge( self::$first_init, $mce_init );
 
             if ( is_array( $set['tinymce'] ) ) {
-                $mceInit = array_merge( $mceInit, $set['tinymce'] );
+                $mce_init = array_merge( $mce_init, $set['tinymce'] );
             }
 
@@ -789 +789 @@
                  * @since 3.3.0 The `$editor_id` parameter was added.
                  *
-                 * @param array  $mceInit   An array with teenyMCE config.
+                 * @param array  $mce_init  An array with teenyMCE config.
                  * @param string $editor_id Unique editor identifier, e.g. 'content'.
                  */
-                $mceInit = apply_filters( 'teeny_mce_before_init', $mceInit, $editor_id );
+                $mce_init = apply_filters( 'teeny_mce_before_init', $mce_init, $editor_id );
             } else {
 
@@ -801 +801 @@
                  * @since 3.3.0 The `$editor_id` parameter was added.
                  *
-                 * @param array  $mceInit   An array with TinyMCE config.
+                 * @param array  $mce_init  An array with TinyMCE config.
                  * @param string $editor_id Unique editor identifier, e.g. 'content'. Accepts 'classic-block'
                  *                          when called from block editor's Classic block.
                  */
-                $mceInit = apply_filters( 'tiny_mce_before_init', $mceInit, $editor_id );
-            }
-
-            if ( empty( $mceInit['toolbar3'] ) && ! empty( $mceInit['toolbar4'] ) ) {
-                $mceInit['toolbar3'] = $mceInit['toolbar4'];
-                $mceInit['toolbar4'] = '';
-            }
-
-            self::$mce_settings[ $editor_id ] = $mceInit;
+                $mce_init = apply_filters( 'tiny_mce_before_init', $mce_init, $editor_id );
+            }
+
+            if ( empty( $mce_init['toolbar3'] ) && ! empty( $mce_init['toolbar4'] ) ) {
+                $mce_init['toolbar3'] = $mce_init['toolbar4'];
+                $mce_init['toolbar4'] = '';
+            }
+
+            self::$mce_settings[ $editor_id ] = $mce_init;
         } // End if self::$this_tinymce.
     }
@@ -1568 +1568 @@
         global $tinymce_version;
 
-        $tmce_on = ! empty( self::$mce_settings );
-        $mceInit = '';
-        $qtInit  = '';
+        $tmce_on  = ! empty( self::$mce_settings );
+        $mce_init = '';
+        $qt_init  = '';
 
         if ( $tmce_on ) {
             foreach ( self::$mce_settings as $editor_id => $init ) {
-                $options  = self::_parse_init( $init );
-                $mceInit .= "'$editor_id':{$options},";
-            }
-            $mceInit = '{' . trim( $mceInit, ',' ) . '}';
+                $options   = self::_parse_init( $init );
+                $mce_init .= "'$editor_id':{$options},";
+            }
+            $mce_init = '{' . trim( $mce_init, ',' ) . '}';
         } else {
-            $mceInit = '{}';
+            $mce_init = '{}';
         }
 
         if ( ! empty( self::$qt_settings ) ) {
             foreach ( self::$qt_settings as $editor_id => $init ) {
-                $options = self::_parse_init( $init );
-                $qtInit .= "'$editor_id':{$options},";
-            }
-            $qtInit = '{' . trim( $qtInit, ',' ) . '}';
+                $options  = self::_parse_init( $init );
+                $qt_init .= "'$editor_id':{$options},";
+            }
+            $qt_init = '{' . trim( $qt_init, ',' ) . '}';
         } else {
-            $qtInit = '{}';
+            $qt_init = '{}';
         }
 
@@ -1623 +1623 @@
 
             ?>
-            mceInit: <?php echo $mceInit; ?>,
-            qtInit: <?php echo $qtInit; ?>,
+            mceInit: <?php echo $mce_init; ?>,
+            qtInit: <?php echo $qt_init; ?>,
             ref: <?php echo self::_parse_init( $ref ); ?>,
             load_ext: function(url,lang){var sl=tinymce.ScriptLoader;sl.markDone(url+'/langs/'+lang+'.js');sl.markDone(url+'/langs/'+lang+'_dlg.js');}