Changeset 55653

Timestamp:

04/16/2023 10:46:17 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison where substr() is involved.

Follow-up to [3606], [10738], [33359], [55642], [55652].

Props aristath, poena, afercia, SergeyBiryukov.
See #57839.

Location:

trunk/src

Files:

• wp-admin/includes/deprecated.php (modified) (1 diff)
• wp-includes/deprecated.php (modified) (4 diffs)
• wp-includes/kses.php (modified) (1 diff)

trunk/src/wp-admin/includes/deprecated.php

@@ -1366 +1366 @@
             reset( $plugin_slugs );
             foreach ( $plugin_slugs as $plugin_slug ) {
-                if ( $slug == substr( $plugin_slug, 0, strlen( $slug ) ) ) {
+                if ( $slug === substr( $plugin_slug, 0, strlen( $slug ) ) ) {
                     unset( $items[$item_key] );
                     continue 2;

trunk/src/wp-includes/deprecated.php

@@ -948 +948 @@
 
     $order = 'ASC';
-    if ( substr($orderby, 0, 1) == '_' ) {
+    if ( substr($orderby, 0, 1) === '_' ) {
         $order = 'DESC';
         $orderby = substr($orderby, 1);
@@ -981 +981 @@
 
         if ( $show_updated )
-            if (substr($row->link_updated_f, 0, 2) != '00')
+            if (substr($row->link_updated_f, 0, 2) !== '00')
                 $title .= ' ('.__('Last updated') . ' ' . gmdate(get_option('links_updated_date_format'), $row->link_updated_f + (get_option('gmt_offset') * HOUR_IN_SECONDS)) . ')';
 
@@ -1043 +1043 @@
     // Handle link category sorting.
     $direction = 'ASC';
-    if ( '_' == substr($order,0,1) ) {
+    if ( '_' === substr($order,0,1) ) {
         $direction = 'DESC';
         $order = substr($order,1);
@@ -1740 +1740 @@
         $link_text = $matches[4][$i];
         $content = str_replace( $link_match, $link_text . ' ' . $link_number, $content );
-        $link_url = ( ( strtolower( substr( $link_url, 0, 7 ) ) != 'http://' ) && ( strtolower( substr( $link_url, 0, 8 ) ) != 'https://' ) ) ? get_option( 'home' ) . $link_url : $link_url;
+        $link_url = ( ( strtolower( substr( $link_url, 0, 7 ) ) !== 'http://' ) && ( strtolower( substr( $link_url, 0, 8 ) ) !== 'https://' ) ) ? get_option( 'home' ) . $link_url : $link_url;
         $links_summary .= "\n" . $link_number . ' ' . $link_url;
     }

trunk/src/wp-includes/kses.php

@@ -800 +800 @@
         }
         if ( '"' === $quote || "'" === $quote ) {
-            if ( substr( $value, -1 ) != $quote ) {
+            if ( substr( $value, -1 ) !== $quote ) {
                 return '';
             }