Changeset 55675

Timestamp:

04/21/2023 01:30:11 PM (3 years ago)

Author:

zieladam

Message:

HTML API: Fix a case where updates are overlooked when seeking to earlier locations.

This retains the WP_HTML_Tag_Processor attribute updates applied before calling seek() – they were erroneously erased in some cases.

Props dmsnell.
Fixes #58160.

Location:

trunk

Files:

• src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlTagProcessor.php (modified) (1 diff)

trunk/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -2143 +2143 @@
                  */
                 if ( $requires_no_updating && $this->bytes_already_copied > 0 ) {
+                        $this->html                 = $this->output_buffer . substr( $this->html, $this->bytes_already_copied );
+                        $this->bytes_already_copied = strlen( $this->output_buffer );
                         return $this->output_buffer . substr( $this->html, $this->bytes_already_copied );
                 }

trunk/tests/phpunit/tests/html-api/wpHtmlTagProcessor.php

@@ -458 +458 @@
 
         /**
+         * Ensures that when seeking to an earlier spot in the document that
+         * all previously-enqueued updates are applied as they ought to be.
+         *
+         * @ticket 58160
+         */
+        public function test_get_updated_html_applies_updates_to_content_after_seeking_to_before_parsed_bytes() {
+                $p = new WP_HTML_Tag_Processor( '<div><img hidden></div>' );
+
+                $p->next_tag();
+                $p->set_attribute( 'wonky', true );
+                $p->next_tag();
+                $p->set_bookmark( 'here' );
+
+                $p->next_tag( array( 'tag_closers' => 'visit' ) );
+                $p->seek( 'here' );
+
+                $this->assertSame( '<div wonky><img hidden></div>', $p->get_updated_html() );
+        }
+
+        /**
          * @ticket 56299
          *