Changeset 55678

Timestamp:

04/23/2023 04:00:26 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-admin/includes/class-wp-site-icon.php.

Follow-up to [32994], [35299].

Props aristath, poena, afercia, SergeyBiryukov.
See #57839.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-site-icon.php (modified) (2 diffs)
• wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-site-icon.php

@@ -202 +202 @@
      */
     public function delete_attachment_data( $post_id ) {
-        $site_icon_id = get_option( 'site_icon' );
-
-        if ( $site_icon_id && $post_id == $site_icon_id ) {
+        $site_icon_id = (int) get_option( 'site_icon' );
+
+        if ( $site_icon_id && $post_id === $site_icon_id ) {
             delete_option( 'site_icon' );
         }
@@ -223 +223 @@
     public function get_post_metadata( $value, $post_id, $meta_key, $single ) {
         if ( $single && '_wp_attachment_backup_sizes' === $meta_key ) {
-            $site_icon_id = get_option( 'site_icon' );
-
-            if ( $post_id == $site_icon_id ) {
+            $site_icon_id = (int) get_option( 'site_icon' );
+
+            if ( $post_id === $site_icon_id ) {
                 add_filter( 'intermediate_image_sizes', array( $this, 'intermediate_image_sizes' ) );
             }

trunk/src/wp-includes/general-template.php

@@ -957 +957 @@
     }
 
-    $site_icon_id = get_option( 'site_icon' );
+    $site_icon_id = (int) get_option( 'site_icon' );
 
     if ( $site_icon_id ) {