Changeset 55701 for trunk/src/wp-includes/post.php

Timestamp:

05/02/2023 10:55:57 AM (3 years ago)

Author:

spacedmonkey

Message:

Taxonomy: Remove redundant call to get_term in wp_queue_posts_for_term_meta_lazyload.

In [55252] the function wp_queue_posts_for_term_meta_lazyload was refactored to use wp_cache_get_multiple. This refactor included a call to get_term. However, calling get_term calls sanitize_term, which sanitizes all fields in a term. The full term object is not needed in this context as term meta only needs to the term id, which is already in the function. Saving calls to sanitize_term will improve performance of this function.

Props spacedmonkey, joemcgill, mukesh27.
Fixes #57966.

File:

• trunk/src/wp-includes/post.php (modified) (3 diffs)

trunk/src/wp-includes/post.php

@@ -7654 +7654 @@
         $term_ids = array();
         if ( $prime_post_terms ) {
-                $prime_term_ids     = array();
-                $prime_taxonomy_ids = array();
                 foreach ( $prime_post_terms as $taxonomy => $post_ids ) {
                         $cached_term_ids = wp_cache_get_multiple( $post_ids, "{$taxonomy}_relationships" );
@@ -7664 +7662 @@
                                         foreach ( $_term_ids as $term_id ) {
                                                 if ( is_numeric( $term_id ) ) {
-                                                        $prime_term_ids[]                  = (int) $term_id;
-                                                        $prime_taxonomy_ids[ $taxonomy ][] = (int) $term_id;
+                                                        $term_ids[] = (int) $term_id;
                                                 } elseif ( isset( $term_id->term_id ) ) {
-                                                        $prime_taxonomy_ids[ $taxonomy ][] = (int) $term_id->term_id;
-                                                        $prime_term_ids[]                  = (int) $term_id->term_id;
+                                                        $term_ids[] = (int) $term_id->term_id;
                                                 }
                                         }
@@ -7674 +7670 @@
                         }
                 }
-
-                if ( $prime_term_ids ) {
-                        $prime_term_ids = array_unique( $prime_term_ids );
-                        // Do not prime term meta at this point, let the lazy loader take care of that.
-                        _prime_term_caches( $prime_term_ids, false );
-
-                        foreach ( $prime_taxonomy_ids as $taxonomy => $_term_ids ) {
-                                foreach ( $_term_ids as $term_id ) {
-                                        if ( in_array( $term_id, $term_ids, true ) ) {
-                                                continue;
-                                        }
-                                        $term = get_term( $term_id, $taxonomy );
-                                        if ( is_wp_error( $term ) ) {
-                                                continue;
-                                        }
-
-                                        $term_ids[] = $term_id;
-                                }
-                        }
-                }
+                $term_ids = array_unique( $term_ids );
         }