Changeset 55703 for trunk/src/wp-admin/includes/class-file-upload-upgrader.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-admin/includes/class-file-upload-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-file-upload-upgrader.php

@@ -109 +109 @@
             $this->package  = $uploads['basedir'] . '/' . $this->filename;
 
-            if ( 0 !== strpos( realpath( $this->package ), realpath( $uploads['basedir'] ) ) ) {
+            if ( ! str_starts_with( realpath( $this->package ), realpath( $uploads['basedir'] ) ) ) {
                 wp_die( __( 'Please select a file' ) );
             }