Changeset 55703 for trunk/src/wp-admin/includes/file.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-admin/includes/file.php (modified) (3 diffs)

trunk/src/wp-admin/includes/file.php

@@ -998 +998 @@
 
         if ( false === $move_new_file ) {
-            if ( 0 === strpos( $uploads['basedir'], ABSPATH ) ) {
+            if ( str_starts_with( $uploads['basedir'], ABSPATH ) ) {
                 $error_path = str_replace( ABSPATH, '', $uploads['basedir'] ) . $uploads['subdir'];
             } else {
@@ -1197 +1197 @@
         $content_disposition = strtolower( $content_disposition );
 
-        if ( 0 === strpos( $content_disposition, 'attachment; filename=' ) ) {
+        if ( str_starts_with( $content_disposition, 'attachment; filename=' ) ) {
             $tmpfname_disposition = sanitize_file_name( substr( $content_disposition, 21 ) );
         } else {
@@ -1938 +1938 @@
 
             foreach ( $skip_list as $skip_item ) {
-                if ( 0 === strpos( $skip_item, $filename . '/' ) ) {
+                if ( str_starts_with( $skip_item, $filename . '/' ) ) {
                     $sub_skip_list[] = preg_replace( '!^' . preg_quote( $filename, '!' ) . '/!i', '', $skip_item );
                 }