Make WordPress Core


Ignore:
Timestamp:
05/02/2023 03:43:03 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/file.php

    r55538 r55703  
    998998
    999999        if ( false === $move_new_file ) {
    1000             if ( 0 === strpos( $uploads['basedir'], ABSPATH ) ) {
     1000            if ( str_starts_with( $uploads['basedir'], ABSPATH ) ) {
    10011001                $error_path = str_replace( ABSPATH, '', $uploads['basedir'] ) . $uploads['subdir'];
    10021002            } else {
     
    11971197        $content_disposition = strtolower( $content_disposition );
    11981198
    1199         if ( 0 === strpos( $content_disposition, 'attachment; filename=' ) ) {
     1199        if ( str_starts_with( $content_disposition, 'attachment; filename=' ) ) {
    12001200            $tmpfname_disposition = sanitize_file_name( substr( $content_disposition, 21 ) );
    12011201        } else {
     
    19381938
    19391939            foreach ( $skip_list as $skip_item ) {
    1940                 if ( 0 === strpos( $skip_item, $filename . '/' ) ) {
     1940                if ( str_starts_with( $skip_item, $filename . '/' ) ) {
    19411941                    $sub_skip_list[] = preg_replace( '!^' . preg_quote( $filename, '!' ) . '/!i', '', $skip_item );
    19421942                }
Note: See TracChangeset for help on using the changeset viewer.