Make WordPress Core


Ignore:
Timestamp:
05/02/2023 03:43:03 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/media.php

    r55684 r55703  
    386386
    387387        // Use image exif/iptc data for title and caption defaults if possible.
    388     } elseif ( 0 === strpos( $type, 'image/' ) ) {
     388    } elseif ( str_starts_with( $type, 'image/' ) ) {
    389389        $image_meta = wp_read_image_metadata( $file );
    390390
     
    535535    // Check callback name for 'media'.
    536536    if (
    537         ( is_array( $content_func ) && ! empty( $content_func[1] ) && 0 === strpos( (string) $content_func[1], 'media' ) ) ||
    538         ( ! is_array( $content_func ) && 0 === strpos( $content_func, 'media' ) )
     537        ( is_array( $content_func ) && ! empty( $content_func[1] ) && str_starts_with( (string) $content_func[1], 'media' ) ) ||
     538        ( ! is_array( $content_func ) && str_starts_with( $content_func, 'media' ) )
    539539    ) {
    540540        wp_enqueue_style( 'deprecated-media' );
     
    35083508                    $metadata[ $key ] = wp_kses_post( reset( $list ) );
    35093509                    // Fix bug in byte stream analysis.
    3510                     if ( 'terms_of_use' === $key && 0 === strpos( $metadata[ $key ], 'yright notice.' ) ) {
     3510                    if ( 'terms_of_use' === $key && str_starts_with( $metadata[ $key ], 'yright notice.' ) ) {
    35113511                        $metadata[ $key ] = 'Cop' . $metadata[ $key ];
    35123512                    }
Note: See TracChangeset for help on using the changeset viewer.