Changeset 55703 for trunk/src/wp-admin/menu-header.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-admin/menu-header.php (modified) (1 diff)

trunk/src/wp-admin/menu-header.php

@@ -128 +128 @@
             if ( 'none' === $item[6] || 'div' === $item[6] ) {
                 $img = '<br />';
-            } elseif ( 0 === strpos( $item[6], 'data:image/svg+xml;base64,' ) ) {
+            } elseif ( str_starts_with( $item[6], 'data:image/svg+xml;base64,' ) ) {
                 $img = '<br />';
                 // The value is base64-encoded data, so esc_attr() is used here instead of esc_url().
                 $img_style = ' style="background-image:url(\'' . esc_attr( $item[6] ) . '\')"';
                 $img_class = ' svg';
-            } elseif ( 0 === strpos( $item[6], 'dashicons-' ) ) {
+            } elseif ( str_starts_with( $item[6], 'dashicons-' ) ) {
                 $img       = '<br />';
                 $img_class = ' dashicons-before ' . sanitize_html_class( $item[6] );