Make WordPress Core


Ignore:
Timestamp:
05/02/2023 03:43:03 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-recovery-mode.php

    r54133 r55703  
    363363        $wp_plugin_dir = wp_normalize_path( WP_PLUGIN_DIR );
    364364
    365         if ( 0 === strpos( $error_file, $wp_plugin_dir ) ) {
     365        if ( str_starts_with( $error_file, $wp_plugin_dir ) ) {
    366366            $path  = str_replace( $wp_plugin_dir . '/', '', $error_file );
    367367            $parts = explode( '/', $path );
     
    380380            $theme_directory = wp_normalize_path( $theme_directory );
    381381
    382             if ( 0 === strpos( $error_file, $theme_directory ) ) {
     382            if ( str_starts_with( $error_file, $theme_directory ) ) {
    383383                $path  = str_replace( $theme_directory . '/', '', $error_file );
    384384                $parts = explode( '/', $path );
     
    414414
    415415        foreach ( $network_plugins as $plugin ) {
    416             if ( 0 === strpos( $plugin, $extension['slug'] . '/' ) ) {
     416            if ( str_starts_with( $plugin, $extension['slug'] . '/' ) ) {
    417417                return true;
    418418            }
Note: See TracChangeset for help on using the changeset viewer.