Changeset 55703 for trunk/src/wp-includes/class-wp-recovery-mode.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-includes/class-wp-recovery-mode.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-recovery-mode.php

@@ -363 +363 @@
         $wp_plugin_dir = wp_normalize_path( WP_PLUGIN_DIR );
 
-        if ( 0 === strpos( $error_file, $wp_plugin_dir ) ) {
+        if ( str_starts_with( $error_file, $wp_plugin_dir ) ) {
             $path  = str_replace( $wp_plugin_dir . '/', '', $error_file );
             $parts = explode( '/', $path );
@@ -380 +380 @@
             $theme_directory = wp_normalize_path( $theme_directory );
 
-            if ( 0 === strpos( $error_file, $theme_directory ) ) {
+            if ( str_starts_with( $error_file, $theme_directory ) ) {
                 $path  = str_replace( $theme_directory . '/', '', $error_file );
                 $parts = explode( '/', $path );
@@ -414 +414 @@
 
         foreach ( $network_plugins as $plugin ) {
-            if ( 0 === strpos( $plugin, $extension['slug'] . '/' ) ) {
+            if ( str_starts_with( $plugin, $extension['slug'] . '/' ) ) {
                 return true;
             }