Changeset 55703 for trunk/src/wp-includes/l10n.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-includes/l10n.php (modified) (5 diffs)

trunk/src/wp-includes/l10n.php

@@ -1085 +1085 @@
     $src = $wp_scripts->registered[ $handle ]->src;
 
-    if ( ! preg_match( '|^(https?:)?//|', $src ) && ! ( $wp_scripts->content_url && 0 === strpos( $src, $wp_scripts->content_url ) ) ) {
+    if ( ! preg_match( '|^(https?:)?//|', $src ) && ! ( $wp_scripts->content_url && str_starts_with( $src, $wp_scripts->content_url ) ) ) {
         $src = $wp_scripts->base_url . $src;
     }
@@ -1099 +1099 @@
     // If the host is the same or it's a relative URL.
     if (
-        ( ! isset( $content_url['path'] ) || strpos( $src_url['path'], $content_url['path'] ) === 0 ) &&
+        ( ! isset( $content_url['path'] ) || str_starts_with( $src_url['path'], $content_url['path'] ) ) &&
         ( ! isset( $src_url['host'] ) || ! isset( $content_url['host'] ) || $src_url['host'] === $content_url['host'] )
     ) {
@@ -1116 +1116 @@
         $relative = implode( '/', $relative );
     } elseif (
-        ( ! isset( $plugins_url['path'] ) || strpos( $src_url['path'], $plugins_url['path'] ) === 0 ) &&
+        ( ! isset( $plugins_url['path'] ) || str_starts_with( $src_url['path'], $plugins_url['path'] ) ) &&
         ( ! isset( $src_url['host'] ) || ! isset( $plugins_url['host'] ) || $src_url['host'] === $plugins_url['host'] )
     ) {
@@ -1135 +1135 @@
         if ( ! isset( $site_url['path'] ) ) {
             $relative = trim( $src_url['path'], '/' );
-        } elseif ( ( strpos( $src_url['path'], trailingslashit( $site_url['path'] ) ) === 0 ) ) {
+        } elseif ( str_starts_with( $src_url['path'], trailingslashit( $site_url['path'] ) ) ) {
             // Make the src relative to the WP root.
             $relative = substr( $src_url['path'], strlen( $site_url['path'] ) );
@@ -1374 +1374 @@
         foreach ( $lang_files as $lang_file ) {
             $lang_file = basename( $lang_file, '.mo' );
-            if ( 0 !== strpos( $lang_file, 'continents-cities' ) && 0 !== strpos( $lang_file, 'ms-' ) &&
-                0 !== strpos( $lang_file, 'admin-' ) ) {
+            if ( ! str_starts_with( $lang_file, 'continents-cities' ) && ! str_starts_with( $lang_file, 'ms-' ) &&
+                ! str_starts_with( $lang_file, 'admin-' ) ) {
                 $languages[] = $lang_file;
             }