Changeset 55703 for trunk/src/wp-includes/post.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-includes/post.php (modified) (4 diffs)

trunk/src/wp-includes/post.php

@@ -724 +724 @@
 
     // If the file is relative, prepend upload dir.
-    if ( $file && 0 !== strpos( $file, '/' ) && ! preg_match( '|^.:\\\|', $file ) ) {
+    if ( $file && ! str_starts_with( $file, '/' ) && ! preg_match( '|^.:\\\|', $file ) ) {
         $uploads = wp_get_upload_dir();
         if ( false === $uploads['error'] ) {
@@ -796 +796 @@
 
     $uploads = wp_get_upload_dir();
-    if ( 0 === strpos( $new_path, $uploads['basedir'] ) ) {
+    if ( str_starts_with( $new_path, $uploads['basedir'] ) ) {
             $new_path = str_replace( $uploads['basedir'], '', $new_path );
             $new_path = ltrim( $new_path, '/' );
@@ -6484 +6484 @@
         if ( $uploads && false === $uploads['error'] ) {
             // Check that the upload base exists in the file location.
-            if ( 0 === strpos( $file, $uploads['basedir'] ) ) {
+            if ( str_starts_with( $file, $uploads['basedir'] ) ) {
                 // Replace file location with url location.
                 $url = str_replace( $uploads['basedir'], $uploads['baseurl'], $file );
@@ -6613 +6613 @@
     }
 
-    if ( 0 === strpos( $post->post_mime_type, $type . '/' ) ) {
+    if ( str_starts_with( $post->post_mime_type, $type . '/' ) ) {
         return true;
     }