Make WordPress Core


Ignore:
Timestamp:
05/02/2023 03:43:03 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api.php

    r55293 r55703  
    940940        // Check to see if $field is the parent of any item in $fields.
    941941        // A field "parent" should be accepted if "parent.child" is accepted.
    942         if ( strpos( $accepted_field, "$field." ) === 0 ) {
     942        if ( str_starts_with( $accepted_field, "$field." ) ) {
    943943            return true;
    944944        }
    945945        // Conversely, if "parent" is accepted, all "parent.child" fields
    946946        // should also be accepted.
    947         if ( strpos( $field, "$accepted_field." ) === 0 ) {
     947        if ( str_starts_with( $field, "$accepted_field." ) ) {
    948948            return true;
    949949        }
Note: See TracChangeset for help on using the changeset viewer.