Make WordPress Core


Ignore:
Timestamp:
05/02/2023 03:43:03 PM (15 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rest-api/class-wp-rest-server.php

    r55693 r55703  
    649649            foreach ( $curies as $curie ) {
    650650                $href_prefix = substr( $curie['href'], 0, strpos( $curie['href'], '{rel}' ) );
    651                 if ( strpos( $rel, $href_prefix ) !== 0 ) {
     651                if ( ! str_starts_with( $rel, $href_prefix ) ) {
    652652                    continue;
    653653                }
     
    10451045
    10461046        foreach ( $this->get_namespaces() as $namespace ) {
    1047             if ( 0 === strpos( trailingslashit( ltrim( $path, '/' ) ), $namespace ) ) {
     1047            if ( str_starts_with( trailingslashit( ltrim( $path, '/' ) ), $namespace ) ) {
    10481048                $with_namespace[] = $this->get_routes( $namespace );
    10491049            }
     
    18281828
    18291829        foreach ( $server as $key => $value ) {
    1830             if ( strpos( $key, 'HTTP_' ) === 0 ) {
     1830            if ( str_starts_with( $key, 'HTTP_' ) ) {
    18311831                $headers[ substr( $key, 5 ) ] = $value;
    18321832            } elseif ( 'REDIRECT_HTTP_AUTHORIZATION' === $key && empty( $server['HTTP_AUTHORIZATION'] ) ) {
Note: See TracChangeset for help on using the changeset viewer.