Changeset 55703 for trunk/src/wp-includes/taxonomy.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-includes/taxonomy.php (modified) (2 diffs)

trunk/src/wp-includes/taxonomy.php

@@ -2263 +2263 @@
 
         // Array keys should be preserved for values of $fields that use term_id for keys.
-        if ( ! empty( $args['fields'] ) && 0 === strpos( $args['fields'], 'id=>' ) ) {
+        if ( ! empty( $args['fields'] ) && str_starts_with( $args['fields'], 'id=>' ) ) {
             $terms = $terms + $terms_from_remaining_taxonomies;
         } else {
@@ -3507 +3507 @@
         $object_types = (array) $taxonomy->object_type;
         foreach ( $object_types as &$object_type ) {
-            if ( 0 === strpos( $object_type, 'attachment:' ) ) {
+            if ( str_starts_with( $object_type, 'attachment:' ) ) {
                 list( $object_type ) = explode( ':', $object_type );
             }