Changeset 55703 for trunk/src/wp-includes/theme.php

Timestamp:

05/02/2023 03:43:03 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of strpos() with str_starts_with().

str_starts_with() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins with the given substring (needle).

WordPress core includes a polyfill for str_starts_with() on PHP < 8.0 as of WordPress 5.9.

This commit replaces 0 === strpos( ... ) with str_starts_with() in core files, making the code more readable and consistent, as well as improving performance.

While strpos() is slightly faster than the polyfill on PHP < 8.0, str_starts_with() is noticeably faster on PHP 8.0+, as it is optimized to avoid unnecessarily searching along the whole haystack if it does not find the needle.

Follow-up to [52039], [52040], [52326].

Props spacedmonkey, costdev, sabernhardt, mukesh27, desrosj, jorbin, TobiasBg, ayeshrajans, lgadzhev, SergeyBiryukov.
Fixes #58012.

File:

• trunk/src/wp-includes/theme.php (modified) (2 diffs)

trunk/src/wp-includes/theme.php

@@ -458 +458 @@
      */
     foreach ( $wp_theme_directories as $theme_root ) {
-        if ( 0 === strpos( $theme_root, WP_CONTENT_DIR ) ) {
+        if ( str_starts_with( $theme_root, WP_CONTENT_DIR ) ) {
             $relative_theme_roots[ str_replace( WP_CONTENT_DIR, '', $theme_root ) ] = $theme_root;
         } else {
@@ -635 +635 @@
         if ( in_array( $theme_root, (array) $wp_theme_directories, true ) ) {
             // Absolute path. Make an educated guess. YMMV -- but note the filter below.
-            if ( 0 === strpos( $theme_root, WP_CONTENT_DIR ) ) {
+            if ( str_starts_with( $theme_root, WP_CONTENT_DIR ) ) {
                 $theme_root_uri = content_url( str_replace( WP_CONTENT_DIR, '', $theme_root ) );
-            } elseif ( 0 === strpos( $theme_root, ABSPATH ) ) {
+            } elseif ( str_starts_with( $theme_root, ABSPATH ) ) {
                 $theme_root_uri = site_url( str_replace( ABSPATH, '', $theme_root ) );
-            } elseif ( 0 === strpos( $theme_root, WP_PLUGIN_DIR ) || 0 === strpos( $theme_root, WPMU_PLUGIN_DIR ) ) {
+            } elseif ( str_starts_with( $theme_root, WP_PLUGIN_DIR ) || str_starts_with( $theme_root, WPMU_PLUGIN_DIR ) ) {
                 $theme_root_uri = plugins_url( basename( $theme_root ), $theme_root );
             } else {