Changeset 55707

Timestamp:

05/03/2023 11:55:26 AM (18 months ago)

Author:

Bernhard Reiter

Message:

HTML API: Fix a case where updates are overlooked when seeking to earlier locations.

This retains the WP_HTML_Tag_Processor attribute updates applied before calling seek() – they were erroneously erased in some cases.

Props dmsnell, zieladam.
Merges [55675] to the 6.2 branch.
Fixes #58160.

Location:

branches/6.2

Files:

• src/wp-includes/html-api/class-wp-html-tag-processor.php (modified) (1 diff)
• tests/phpunit/tests/html-api/wpHtmlTagProcessor.php (modified) (1 diff)

branches/6.2/src/wp-includes/html-api/class-wp-html-tag-processor.php

@@ -2103 +2103 @@
          */
         if ( $requires_no_updating && $this->bytes_already_copied > 0 ) {
+            $this->html                 = $this->output_buffer . substr( $this->html, $this->bytes_already_copied );
+            $this->bytes_already_copied = strlen( $this->output_buffer );
             return $this->output_buffer . substr( $this->html, $this->bytes_already_copied );
         }

branches/6.2/tests/phpunit/tests/html-api/wpHtmlTagProcessor.php

@@ -405 +405 @@
             'Casting WP_HTML_Tag_Processor to a string without performing any updates did not return the initial HTML snippet'
         );
+    }
+
+    /**
+     * Ensures that when seeking to an earlier spot in the document that
+     * all previously-enqueued updates are applied as they ought to be.
+     *
+     * @ticket 58160
+     */
+    public function test_get_updated_html_applies_updates_to_content_after_seeking_to_before_parsed_bytes() {
+        $p = new WP_HTML_Tag_Processor( '<div><img hidden></div>' );
+
+        $p->next_tag();
+        $p->set_attribute( 'wonky', true );
+        $p->next_tag();
+        $p->set_bookmark( 'here' );
+
+        $p->next_tag( array( 'tag_closers' => 'visit' ) );
+        $p->seek( 'here' );
+
+        $this->assertSame( '<div wonky><img hidden></div>', $p->get_updated_html() );
     }